-
-
Notifications
You must be signed in to change notification settings - Fork 83
feat: Allow overriding the whole assume policy #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Benbentwo
merged 6 commits into
cloudposse:main
from
pablotp:allow-set-custom-assume-policy
Jun 4, 2025
Merged
feat: Allow overriding the whole assume policy #86
Benbentwo
merged 6 commits into
cloudposse:main
from
pablotp:allow-set-custom-assume-policy
Jun 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbc225a
to
4746f86
Compare
nitrocode
reviewed
Jun 3, 2025
/terratest |
Tests are failing. Try running the tests locally. |
4746f86
to
cc2e3c0
Compare
Benbentwo
requested changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple small changes
Co-authored-by: Ben <[email protected]> Co-authored-by: RB <[email protected]>
@Benbentwo, thank you for the prompt review! I've just addressed your comments. Please let me know if I missed anything. |
8a0e64f
to
775ec99
Compare
nitrocode
reviewed
Jun 3, 2025
/terratest |
/terratest |
Benbentwo
previously approved these changes
Jun 4, 2025
b31ea55
to
6596e35
Compare
/terratest |
Benbentwo
approved these changes
Jun 4, 2025
milldr
approved these changes
Jun 4, 2025
These changes were released in v0.22.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adds the assume_role_policy_document variable, allowing users to provide a complete JSON assume role policy for the IAM role. When set, this overrides the principals, assume_role_conditions, and assume_role_actions variables.
why
This enables advanced use cases where a custom trust policy is needed, offering more flexibility than the module’s built-in policy generation. If not set, the module’s default behavior remains unchanged.
Example of an assume policy that couldn't be generated before
With the previous implementation, you could not generate the second statement with a different action (
sts:AssumeRoleWithWebIdentity
) and a different condition for the Federated principal.references