Skip to content

Fix: #41 Make private_ips an optional parameter #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix: #41 Make private_ips an optional parameter #47

wants to merge 2 commits into from

Conversation

noqqe
Copy link

@noqqe noqqe commented Jan 19, 2023

what

Fixes #41

why

  • If private_ips is empty, terraform fails to get a valid input for private_ip

references

@noqqe noqqe requested a review from a team as a code owner January 19, 2023 14:34
@cloudpossebot cloudpossebot requested review from a team as code owners January 19, 2023 14:35
@cloudpossebot cloudpossebot requested review from joe-niland and korenyoni and removed request for a team January 19, 2023 14:35
@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
@hans-d hans-d closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
stale This PR has gone stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Omitting private_ips variable result in terraform error.
3 participants
@noqqe @hans-d @cloudpossebot