Use golangci-lint 2.0.2

Author: mrueg

.golangci.yml

@@ -1,5 +1,10 @@
-run:
-  timeout: 5m
+version: "2"
+output:
+  formats:
+    tab:
+      path: stdout
+      print-linter-name: true
+      colors: false
 linters:
   enable:
     - bodyclose
@@ -11,66 +16,69 @@ linters:
     - gochecknoinits
     - goconst
     - gocritic
-    - gofmt
-    - goimports
     - gosec
-    - govet
     - lll
     - misspell
     - mnd
     - nakedret
     - noctx
     - nolintlint
-    - stylecheck
+    - staticcheck
     - unconvert
     - unparam
-linters-settings:
-  goconst:
-    # Exclude few word constants
-    min-len: 20
-    # Don't use goconst to check test files
-    ignore-tests: true
+  settings:
+    goconst:
+      min-len: 20
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - mnd
+        text: 'Magic number: [0-9]{1},'
+      - linters:
+          - mnd
+        text: 'Magic number: 0[0-7]{3},'
+      - linters:
+          - mnd
+        path: pkg/controllers/proxy/network_services_controller.go
+        text: 'Magic number: 255,'
+      - linters:
+          - mnd
+        text: 'Magic number: 32,'
+      - linters:
+          - mnd
+        text: 'Magic number: 10,'
+      - linters:
+          - gosec
+        text: 'G306:'
+      - linters:
+          - lll
+        path: _test\.go
+      - linters:
+          - dupl
+        path: _test\.go
+      - linters:
+          - goconst
+        path: (.+)_test\.go
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
 issues:
-  exclude-rules:
-    # Excluding single digits from magic number detector because it produces too many obvious results (like klog)
-    - text: "Magic number: [0-9]{1},"
-      linters:
-        - mnd
-    # Exclude file masks from magic number detector because these numbers are obvious
-    - text: "Magic number: 0[0-7]{3},"
-      linters:
-        - mnd
-    # Exlude IP masks netmasks as substituting them for constants only makes these less obvious
-    - text: "Magic number: 255,"
-      linters:
-        - mnd
-      path: pkg/controllers/proxy/network_services_controller.go
-    # Exclude IP netmasks from magic number detector because these numbers are obvious
-    - text: "Magic number: 32,"
-      linters:
-        - mnd
-    # Exclude decimal bases from magic number detector because these numbers are obvious
-    - text: "Magic number: 10,"
-      linters:
-        - mnd
-    # Exclude file mask security findings as we are always intentional about the file masks we use
-    - text: "G306:"
-      linters:
-        - gosec
-    # Exclude tests from long line linter
-    - linters:
-        - lll
-      path: _test\.go
-    # Exclude tests from duplicate linter
-    - linters:
-        - dupl
-      path: _test\.go
-  # always show all issues rather than only showing 50 at a time
   max-issues-per-linter: 0
-  # always show all issues of a type rather than showing 3
   max-same-issues: 0
-output:
-  formats:
-    - format: tab
-  print-issued-lines: true
-  print-linter-name: true
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Makefile

@@ -24,7 +24,7 @@ GO_CACHE?=$(shell go env GOCACHE)
 GO_MOD_CACHE?=$(shell go env GOMODCACHE)
 BUILDTIME_BASE?=$(DOCKER_BUILD_IMAGE)
 RUNTIME_BASE?=alpine:3.21
-DOCKER_LINT_IMAGE?=golangci/golangci-lint:v1.63.4
+DOCKER_LINT_IMAGE?=golangci/golangci-lint:v2.0.2
 DOCKER_MARKDOWNLINT_IMAGE?=tmknom/markdownlint:0.39.0
 GOBGP_VERSION=v3.29.0
 QEMU_IMAGE?=multiarch/qemu-user-static