[fix] efibootorderfix (#16)

Previous efibootorderfix versions were incorrectly specifying the
partition number being passed to `efibootmgr`. This change makes that
more dynamic.

Also, in cases where `/boot/efi` is an actual md mirror, this PR adds
the logic to add EFI boot targets for each of the mirror plexes, instead
of just a single plex of the mirror, so better repliates EFI boot
targets as set up by OS distro installs which automatically make use
of multiple plexes.

Example output after a successful upgrade - note the duplicate
(mirrored) boot entries for "Rocky Linux":

```
BootCurrent: 0005
Timeout: 3 seconds
BootOrder: 0005,0004,0002,0003
Boot0002* UEFI: Built-in EFI Shell	VenMedia(5023b95c-db26-429b-a648-bd47664c8012)..BO
Boot0003* UEFI: PXE IP4 Cisco 1GigE I350 LOM	PciRoot(0x0)/Pci(0x1c,0x0)/Pci(0x0,0x0)/MAC(d4789b4a161c,1)/IPv4(0.0.0.00.0.0.0,0,0)..BO
Boot0004* Rocky Linux	HD(3,GPT,3566f194-fa71-4539-9687-2b20f67841ed,0xa00800,0x80000)/File(\EFI\rocky\shimx64.efi)
Boot0005* Rocky Linux	HD(3,GPT,ad6e8abc-5728-4435-9b84-1c28cb5a18cf,0xa00800,0x80000)/File(\EFI\rocky\shimx64.efi)
```

Author: guzzijason

repos/system_upgrade/common/actors/efibootorderfix/finalization/actor.py

@@ -1,4 +1,5 @@
 import os
+import re
 
 from leapp.libraries.stdlib import run, api
 from leapp.actors import Actor
@@ -38,6 +39,11 @@ def process(self):
             'aarch64': 'shimaa64.efi'
         }
 
+        def devparts(dev):
+          part = next(re.finditer(r'\d+$', dev)).group(0)
+          dev = dev[:-len(part)]
+          return [dev, part];
+
         with open('/etc/system-release', 'r') as sr:
             release_line = next(line for line in sr if 'release' in line)
             distro = release_line.split(' release ', 1)[0]
@@ -69,19 +75,27 @@ def process(self):
                 break
 
         if is_system_efi and has_shim:
+            efidevlist = []
             with open('/proc/mounts', 'r') as fp:
                 for line in fp:
                     if '/boot/efi' in line:
                         efidevpath = line.split(' ', 1)[0]
-                        efidev = efidevpath.split('/')[-1]
+                        efidevpart = efidevpath.split('/')[-1]
             if os.path.exists('/proc/mdstat'):
                with open('/proc/mdstat', 'r') as mds:
                  for line in mds:
-                   if line.startswith(efidev):
-                     mddev = line.split(' ')[-1]
-                     newefidev = mddev.split('[', 1)[0]
-                     efidevpath = efidevpath.replace(efidev, newefidev)
-            run(['/sbin/efibootmgr', '-c', '-d', efidevpath, '-p 1', '-l', bootmgr_path, '-L', efi_bootentry_label])
+                   if line.startswith(efidevpart):
+                     mddev = line.split(' ')
+                     for md in mddev:
+                       if '[' in md:
+                         efimd = md.split('[', 1)[0]
+                         efidp = efidevpath.replace(efidevpart, efimd)
+                         efidevlist.append(efidp)
+            if len(efidevlist) == 0:
+              efidevlist.append(efidevpath)
+            for devpath in efidevlist:
+              efidev, efipart = devparts(devpath)
+              run(['/sbin/efibootmgr', '-c', '-d', efidev, '-p', efipart, '-l', bootmgr_path, '-L', efi_bootentry_label])
 
             if not has_grub_cfg:
                 run(['/sbin/grub2-mkconfig', '-o', grub_cfg_path])