Skip to content

Commit a4e3906

Browse files
authored
Default channel to GA is not specified otherwise (oamg#1205)
Originally we tried to map by default repositories from particular channels on the source system to their equivalents on the target system. IOW: * eus -> eus * aus -> aus * e4s -> e4s * "ga" -> "ga" ... However, it has been revealed this logic should not apply on minor releases for which these non-ga (premium) repositories do not exist. So doing upgrade e.g. to 8.9, 8.10 , 9.3 for which specific eus, etc.. repositories are not defined lead to 404 error. Discussing this deeply between stakeholders, it has been decided to drop this logic and target always to "ga" repositories unless the leapp is executed with instructions to choose a different channel (using envars, --channel .. option). To prevent this issue. It's still possible to require mistakenly e.g. "eus" channel for the target release for which the related repositories are not defined. e.g.: > leapp upgrade --channel eus --target 8.10 In such a case, the previous errors (404 Not found) can be hit again. But it will not happen by default. In this case, we expect and request people to understand what they want when they use the option. @pirat89 : Updated commit msg jira: RHEL-24720
1 parent 8fe2a2d commit a4e3906

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

commands/upgrade/util.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,8 @@ def prepare_configuration(args):
207207

208208
if args.channel:
209209
os.environ['LEAPP_TARGET_PRODUCT_CHANNEL'] = args.channel
210+
elif 'LEAPP_TARGET_PRODUCT_CHANNEL' not in os.environ:
211+
os.environ['LEAPP_TARGET_PRODUCT_CHANNEL'] = 'ga'
210212

211213
if args.iso:
212214
os.environ['LEAPP_TARGET_ISO'] = args.iso

0 commit comments

Comments
 (0)