feat(loa_documents)!: move download subresource into parent as get (#2304)

Author: stainless-app[bot]

api.md

@@ -3218,13 +3218,8 @@ from cloudflare.types.addressing import LOADocumentCreateResponse
 
 Methods:
 
-- <code title="post /accounts/{account_id}/addressing/loa_documents">client.addressing.loa_documents.<a href="./src/cloudflare/resources/addressing/loa_documents/loa_documents.py">create</a>(\*, account_id, \*\*<a href="src/cloudflare/types/addressing/loa_document_create_params.py">params</a>) -> <a href="./src/cloudflare/types/addressing/loa_document_create_response.py">Optional[LOADocumentCreateResponse]</a></code>
-
-### Downloads
-
-Methods:
-
-- <code title="get /accounts/{account_id}/addressing/loa_documents/{loa_document_id}/download">client.addressing.loa_documents.downloads.<a href="./src/cloudflare/resources/addressing/loa_documents/downloads.py">get</a>(loa_document_id, \*, account_id) -> BinaryAPIResponse</code>
+- <code title="post /accounts/{account_id}/addressing/loa_documents">client.addressing.loa_documents.<a href="./src/cloudflare/resources/addressing/loa_documents.py">create</a>(\*, account_id, \*\*<a href="src/cloudflare/types/addressing/loa_document_create_params.py">params</a>) -> <a href="./src/cloudflare/types/addressing/loa_document_create_response.py">Optional[LOADocumentCreateResponse]</a></code>
+- <code title="get /accounts/{account_id}/addressing/loa_documents/{loa_document_id}/download">client.addressing.loa_documents.<a href="./src/cloudflare/resources/addressing/loa_documents.py">get</a>(loa_document_id, \*, account_id) -> BinaryAPIResponse</code>
 
 ## Prefixes
 

src/cloudflare/resources/addressing/addressing.py

@@ -12,6 +12,14 @@
 )
 from ..._compat import cached_property
 from ..._resource import SyncAPIResource, AsyncAPIResource
+from .loa_documents import (
+    LOADocumentsResource,
+    AsyncLOADocumentsResource,
+    LOADocumentsResourceWithRawResponse,
+    AsyncLOADocumentsResourceWithRawResponse,
+    LOADocumentsResourceWithStreamingResponse,
+    AsyncLOADocumentsResourceWithStreamingResponse,
+)
 from .prefixes.prefixes import (
     PrefixesResource,
     AsyncPrefixesResource,
@@ -28,14 +36,6 @@
     AddressMapsResourceWithStreamingResponse,
     AsyncAddressMapsResourceWithStreamingResponse,
 )
-from .loa_documents.loa_documents import (
-    LOADocumentsResource,
-    AsyncLOADocumentsResource,
-    LOADocumentsResourceWithRawResponse,
-    AsyncLOADocumentsResourceWithRawResponse,
-    LOADocumentsResourceWithStreamingResponse,
-    AsyncLOADocumentsResourceWithStreamingResponse,
-)
 from .regional_hostnames.regional_hostnames import (
     RegionalHostnamesResource,
     AsyncRegionalHostnamesResource,

src/cloudflare/resources/addressing/loa_documents/loa_documents.py src/cloudflare/resources/addressing/loa_documents.py

@@ -6,40 +6,36 @@
 
 import httpx
 
-from ...._types import NOT_GIVEN, Body, Query, Headers, NotGiven
-from ...._utils import (
+from ..._types import NOT_GIVEN, Body, Query, Headers, NotGiven
+from ..._utils import (
     maybe_transform,
     async_maybe_transform,
 )
-from .downloads import (
-    DownloadsResource,
-    AsyncDownloadsResource,
-    DownloadsResourceWithRawResponse,
-    AsyncDownloadsResourceWithRawResponse,
-    DownloadsResourceWithStreamingResponse,
-    AsyncDownloadsResourceWithStreamingResponse,
-)
-from ...._compat import cached_property
-from ...._resource import SyncAPIResource, AsyncAPIResource
-from ...._response import (
+from ..._compat import cached_property
+from ..._resource import SyncAPIResource, AsyncAPIResource
+from ..._response import (
+    BinaryAPIResponse,
+    AsyncBinaryAPIResponse,
+    StreamedBinaryAPIResponse,
+    AsyncStreamedBinaryAPIResponse,
     to_raw_response_wrapper,
     to_streamed_response_wrapper,
     async_to_raw_response_wrapper,
+    to_custom_raw_response_wrapper,
     async_to_streamed_response_wrapper,
+    to_custom_streamed_response_wrapper,
+    async_to_custom_raw_response_wrapper,
+    async_to_custom_streamed_response_wrapper,
 )
-from ...._wrappers import ResultWrapper
-from ...._base_client import make_request_options
-from ....types.addressing import loa_document_create_params
-from ....types.addressing.loa_document_create_response import LOADocumentCreateResponse
+from ..._wrappers import ResultWrapper
+from ..._base_client import make_request_options
+from ...types.addressing import loa_document_create_params
+from ...types.addressing.loa_document_create_response import LOADocumentCreateResponse
 
 __all__ = ["LOADocumentsResource", "AsyncLOADocumentsResource"]
 
 
 class LOADocumentsResource(SyncAPIResource):
-    @cached_property
-    def downloads(self) -> DownloadsResource:
-        return DownloadsResource(self._client)
-
     @cached_property
     def with_raw_response(self) -> LOADocumentsResourceWithRawResponse:
         """
@@ -106,12 +102,49 @@ def create(
             cast_to=cast(Type[Optional[LOADocumentCreateResponse]], ResultWrapper[LOADocumentCreateResponse]),
         )
 
+    def get(
+        self,
+        loa_document_id: Optional[str],
+        *,
+        account_id: str,
+        # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
+        # The extra values given here take precedence over values defined on the client or passed to this method.
+        extra_headers: Headers | None = None,
+        extra_query: Query | None = None,
+        extra_body: Body | None = None,
+        timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN,
+    ) -> BinaryAPIResponse:
+        """
+        Download specified LOA document under the account.
 
-class AsyncLOADocumentsResource(AsyncAPIResource):
-    @cached_property
-    def downloads(self) -> AsyncDownloadsResource:
-        return AsyncDownloadsResource(self._client)
+        Args:
+          account_id: Identifier
+
+          loa_document_id: Identifier for the uploaded LOA document.
+
+          extra_headers: Send extra headers
+
+          extra_query: Add additional query parameters to the request
+
+          extra_body: Add additional JSON properties to the request
 
+          timeout: Override the client-level default timeout for this request, in seconds
+        """
+        if not account_id:
+            raise ValueError(f"Expected a non-empty value for `account_id` but received {account_id!r}")
+        if not loa_document_id:
+            raise ValueError(f"Expected a non-empty value for `loa_document_id` but received {loa_document_id!r}")
+        extra_headers = {"Accept": "application/pdf", **(extra_headers or {})}
+        return self._get(
+            f"/accounts/{account_id}/addressing/loa_documents/{loa_document_id}/download",
+            options=make_request_options(
+                extra_headers=extra_headers, extra_query=extra_query, extra_body=extra_body, timeout=timeout
+            ),
+            cast_to=BinaryAPIResponse,
+        )
+
+
+class AsyncLOADocumentsResource(AsyncAPIResource):
     @cached_property
     def with_raw_response(self) -> AsyncLOADocumentsResourceWithRawResponse:
         """
@@ -180,6 +213,47 @@ async def create(
             cast_to=cast(Type[Optional[LOADocumentCreateResponse]], ResultWrapper[LOADocumentCreateResponse]),
         )
 
+    async def get(
+        self,
+        loa_document_id: Optional[str],
+        *,
+        account_id: str,
+        # Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
+        # The extra values given here take precedence over values defined on the client or passed to this method.
+        extra_headers: Headers | None = None,
+        extra_query: Query | None = None,
+        extra_body: Body | None = None,
+        timeout: float | httpx.Timeout | None | NotGiven = NOT_GIVEN,
+    ) -> AsyncBinaryAPIResponse:
+        """
+        Download specified LOA document under the account.
+
+        Args:
+          account_id: Identifier
+
+          loa_document_id: Identifier for the uploaded LOA document.
+
+          extra_headers: Send extra headers
+
+          extra_query: Add additional query parameters to the request
+
+          extra_body: Add additional JSON properties to the request
+
+          timeout: Override the client-level default timeout for this request, in seconds
+        """
+        if not account_id:
+            raise ValueError(f"Expected a non-empty value for `account_id` but received {account_id!r}")
+        if not loa_document_id:
+            raise ValueError(f"Expected a non-empty value for `loa_document_id` but received {loa_document_id!r}")
+        extra_headers = {"Accept": "application/pdf", **(extra_headers or {})}
+        return await self._get(
+            f"/accounts/{account_id}/addressing/loa_documents/{loa_document_id}/download",
+            options=make_request_options(
+                extra_headers=extra_headers, extra_query=extra_query, extra_body=extra_body, timeout=timeout
+            ),
+            cast_to=AsyncBinaryAPIResponse,
+        )
+
 
 class LOADocumentsResourceWithRawResponse:
     def __init__(self, loa_documents: LOADocumentsResource) -> None:
@@ -188,10 +262,10 @@ def __init__(self, loa_documents: LOADocumentsResource) -> None:
         self.create = to_raw_response_wrapper(
             loa_documents.create,
         )
-
-    @cached_property
-    def downloads(self) -> DownloadsResourceWithRawResponse:
-        return DownloadsResourceWithRawResponse(self._loa_documents.downloads)
+        self.get = to_custom_raw_response_wrapper(
+            loa_documents.get,
+            BinaryAPIResponse,
+        )
 
 
 class AsyncLOADocumentsResourceWithRawResponse:
@@ -201,10 +275,10 @@ def __init__(self, loa_documents: AsyncLOADocumentsResource) -> None:
         self.create = async_to_raw_response_wrapper(
             loa_documents.create,
         )
-
-    @cached_property
-    def downloads(self) -> AsyncDownloadsResourceWithRawResponse:
-        return AsyncDownloadsResourceWithRawResponse(self._loa_documents.downloads)
+        self.get = async_to_custom_raw_response_wrapper(
+            loa_documents.get,
+            AsyncBinaryAPIResponse,
+        )
 
 
 class LOADocumentsResourceWithStreamingResponse:
@@ -214,10 +288,10 @@ def __init__(self, loa_documents: LOADocumentsResource) -> None:
         self.create = to_streamed_response_wrapper(
             loa_documents.create,
         )
-
-    @cached_property
-    def downloads(self) -> DownloadsResourceWithStreamingResponse:
-        return DownloadsResourceWithStreamingResponse(self._loa_documents.downloads)
+        self.get = to_custom_streamed_response_wrapper(
+            loa_documents.get,
+            StreamedBinaryAPIResponse,
+        )
 
 
 class AsyncLOADocumentsResourceWithStreamingResponse:
@@ -227,7 +301,7 @@ def __init__(self, loa_documents: AsyncLOADocumentsResource) -> None:
         self.create = async_to_streamed_response_wrapper(
             loa_documents.create,
         )
-
-    @cached_property
-    def downloads(self) -> AsyncDownloadsResourceWithStreamingResponse:
-        return AsyncDownloadsResourceWithStreamingResponse(self._loa_documents.downloads)
+        self.get = async_to_custom_streamed_response_wrapper(
+            loa_documents.get,
+            AsyncStreamedBinaryAPIResponse,
+        )