Skip to content

Commit b04ba76

Browse files
feat(cloud_connector): define body param name (#2314)
1 parent 8f97535 commit b04ba76

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

src/cloudflare/resources/cloud_connector/rules.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def update(
5353
self,
5454
*,
5555
zone_id: str,
56-
body: Iterable[rule_update_params.Body],
56+
rules: Iterable[rule_update_params.Rule],
5757
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
5858
# The extra values given here take precedence over values defined on the client or passed to this method.
5959
extra_headers: Headers | None = None,
@@ -67,7 +67,7 @@ def update(
6767
Args:
6868
zone_id: Identifier
6969
70-
body: List of Cloud Connector rules
70+
rules: List of Cloud Connector rules
7171
7272
extra_headers: Send extra headers
7373
@@ -81,7 +81,7 @@ def update(
8181
raise ValueError(f"Expected a non-empty value for `zone_id` but received {zone_id!r}")
8282
return self._put(
8383
f"/zones/{zone_id}/cloud_connector/rules",
84-
body=maybe_transform(body, Iterable[rule_update_params.Body]),
84+
body=maybe_transform(rules, Iterable[rule_update_params.Rule]),
8585
options=make_request_options(
8686
extra_headers=extra_headers,
8787
extra_query=extra_query,
@@ -153,7 +153,7 @@ async def update(
153153
self,
154154
*,
155155
zone_id: str,
156-
body: Iterable[rule_update_params.Body],
156+
rules: Iterable[rule_update_params.Rule],
157157
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
158158
# The extra values given here take precedence over values defined on the client or passed to this method.
159159
extra_headers: Headers | None = None,
@@ -167,7 +167,7 @@ async def update(
167167
Args:
168168
zone_id: Identifier
169169
170-
body: List of Cloud Connector rules
170+
rules: List of Cloud Connector rules
171171
172172
extra_headers: Send extra headers
173173
@@ -181,7 +181,7 @@ async def update(
181181
raise ValueError(f"Expected a non-empty value for `zone_id` but received {zone_id!r}")
182182
return await self._put(
183183
f"/zones/{zone_id}/cloud_connector/rules",
184-
body=await async_maybe_transform(body, Iterable[rule_update_params.Body]),
184+
body=await async_maybe_transform(rules, Iterable[rule_update_params.Rule]),
185185
options=make_request_options(
186186
extra_headers=extra_headers,
187187
extra_query=extra_query,

src/cloudflare/types/cloud_connector/rule_update_params.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,23 @@
55
from typing import Iterable
66
from typing_extensions import Literal, Required, TypedDict
77

8-
__all__ = ["RuleUpdateParams", "Body", "BodyParameters"]
8+
__all__ = ["RuleUpdateParams", "Rule", "RuleParameters"]
99

1010

1111
class RuleUpdateParams(TypedDict, total=False):
1212
zone_id: Required[str]
1313
"""Identifier"""
1414

15-
body: Required[Iterable[Body]]
15+
rules: Required[Iterable[Rule]]
1616
"""List of Cloud Connector rules"""
1717

1818

19-
class BodyParameters(TypedDict, total=False):
19+
class RuleParameters(TypedDict, total=False):
2020
host: str
2121
"""Host to perform Cloud Connection to"""
2222

2323

24-
class Body(TypedDict, total=False):
24+
class Rule(TypedDict, total=False):
2525
id: str
2626

2727
description: str
@@ -30,7 +30,7 @@ class Body(TypedDict, total=False):
3030

3131
expression: str
3232

33-
parameters: BodyParameters
33+
parameters: RuleParameters
3434
"""Parameters of Cloud Connector Rule"""
3535

3636
provider: Literal["aws_s3", "r2", "gcp_storage", "azure_storage"]

tests/api_resources/cloud_connector/test_rules.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ class TestRules:
2222
def test_method_update(self, client: Cloudflare) -> None:
2323
rule = client.cloud_connector.rules.update(
2424
zone_id="023e105f4ecef8ad9ca31a8372d0c353",
25-
body=[{}],
25+
rules=[{}],
2626
)
2727
assert_matches_type(Optional[RuleUpdateResponse], rule, path=["response"])
2828

2929
@parametrize
3030
def test_raw_response_update(self, client: Cloudflare) -> None:
3131
response = client.cloud_connector.rules.with_raw_response.update(
3232
zone_id="023e105f4ecef8ad9ca31a8372d0c353",
33-
body=[{}],
33+
rules=[{}],
3434
)
3535

3636
assert response.is_closed is True
@@ -42,7 +42,7 @@ def test_raw_response_update(self, client: Cloudflare) -> None:
4242
def test_streaming_response_update(self, client: Cloudflare) -> None:
4343
with client.cloud_connector.rules.with_streaming_response.update(
4444
zone_id="023e105f4ecef8ad9ca31a8372d0c353",
45-
body=[{}],
45+
rules=[{}],
4646
) as response:
4747
assert not response.is_closed
4848
assert response.http_request.headers.get("X-Stainless-Lang") == "python"
@@ -57,7 +57,7 @@ def test_path_params_update(self, client: Cloudflare) -> None:
5757
with pytest.raises(ValueError, match=r"Expected a non-empty value for `zone_id` but received ''"):
5858
client.cloud_connector.rules.with_raw_response.update(
5959
zone_id="",
60-
body=[{}],
60+
rules=[{}],
6161
)
6262

6363
@parametrize
@@ -106,15 +106,15 @@ class TestAsyncRules:
106106
async def test_method_update(self, async_client: AsyncCloudflare) -> None:
107107
rule = await async_client.cloud_connector.rules.update(
108108
zone_id="023e105f4ecef8ad9ca31a8372d0c353",
109-
body=[{}],
109+
rules=[{}],
110110
)
111111
assert_matches_type(Optional[RuleUpdateResponse], rule, path=["response"])
112112

113113
@parametrize
114114
async def test_raw_response_update(self, async_client: AsyncCloudflare) -> None:
115115
response = await async_client.cloud_connector.rules.with_raw_response.update(
116116
zone_id="023e105f4ecef8ad9ca31a8372d0c353",
117-
body=[{}],
117+
rules=[{}],
118118
)
119119

120120
assert response.is_closed is True
@@ -126,7 +126,7 @@ async def test_raw_response_update(self, async_client: AsyncCloudflare) -> None:
126126
async def test_streaming_response_update(self, async_client: AsyncCloudflare) -> None:
127127
async with async_client.cloud_connector.rules.with_streaming_response.update(
128128
zone_id="023e105f4ecef8ad9ca31a8372d0c353",
129-
body=[{}],
129+
rules=[{}],
130130
) as response:
131131
assert not response.is_closed
132132
assert response.http_request.headers.get("X-Stainless-Lang") == "python"
@@ -141,7 +141,7 @@ async def test_path_params_update(self, async_client: AsyncCloudflare) -> None:
141141
with pytest.raises(ValueError, match=r"Expected a non-empty value for `zone_id` but received ''"):
142142
await async_client.cloud_connector.rules.with_raw_response.update(
143143
zone_id="",
144-
body=[{}],
144+
rules=[{}],
145145
)
146146

147147
@parametrize

0 commit comments

Comments
 (0)