Skip to content

Commit a88b77d

Browse files
stainless-app[bot]stainless-bot
authored andcommitted
fix(waiting_room_rules): define body_param_name for bulk rules endpoint (#2139)
1 parent 74f433a commit a88b77d

File tree

4 files changed

+78
-88
lines changed

4 files changed

+78
-88
lines changed

src/cloudflare/resources/waiting_rooms/rules.py

+8-46
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,7 @@ def create(
5757
waiting_room_id: str,
5858
*,
5959
zone_id: str,
60-
action: Literal["bypass_waiting_room"],
61-
expression: str,
62-
description: str | NotGiven = NOT_GIVEN,
63-
enabled: bool | NotGiven = NOT_GIVEN,
60+
rules: rule_create_params.Rules,
6461
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
6562
# The extra values given here take precedence over values defined on the client or passed to this method.
6663
extra_headers: Headers | None = None,
@@ -76,14 +73,6 @@ def create(
7673
Args:
7774
zone_id: Identifier
7875
79-
action: The action to take when the expression matches.
80-
81-
expression: Criteria defining when there is a match for the current rule.
82-
83-
description: The description of the rule.
84-
85-
enabled: When set to true, the rule is enabled.
86-
8776
extra_headers: Send extra headers
8877
8978
extra_query: Add additional query parameters to the request
@@ -98,15 +87,7 @@ def create(
9887
raise ValueError(f"Expected a non-empty value for `waiting_room_id` but received {waiting_room_id!r}")
9988
return self._post(
10089
f"/zones/{zone_id}/waiting_rooms/{waiting_room_id}/rules",
101-
body=maybe_transform(
102-
{
103-
"action": action,
104-
"expression": expression,
105-
"description": description,
106-
"enabled": enabled,
107-
},
108-
rule_create_params.RuleCreateParams,
109-
),
90+
body=maybe_transform(rules, rule_create_params.RuleCreateParams),
11091
options=make_request_options(
11192
extra_headers=extra_headers,
11293
extra_query=extra_query,
@@ -122,7 +103,7 @@ def update(
122103
waiting_room_id: str,
123104
*,
124105
zone_id: str,
125-
body: Iterable[rule_update_params.Body],
106+
rules: Iterable[rule_update_params.Rule],
126107
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
127108
# The extra values given here take precedence over values defined on the client or passed to this method.
128109
extra_headers: Headers | None = None,
@@ -152,7 +133,7 @@ def update(
152133
raise ValueError(f"Expected a non-empty value for `waiting_room_id` but received {waiting_room_id!r}")
153134
return self._put(
154135
f"/zones/{zone_id}/waiting_rooms/{waiting_room_id}/rules",
155-
body=maybe_transform(body, Iterable[rule_update_params.Body]),
136+
body=maybe_transform(rules, Iterable[rule_update_params.Rule]),
156137
options=make_request_options(
157138
extra_headers=extra_headers,
158139
extra_query=extra_query,
@@ -350,10 +331,7 @@ async def create(
350331
waiting_room_id: str,
351332
*,
352333
zone_id: str,
353-
action: Literal["bypass_waiting_room"],
354-
expression: str,
355-
description: str | NotGiven = NOT_GIVEN,
356-
enabled: bool | NotGiven = NOT_GIVEN,
334+
rules: rule_create_params.Rules,
357335
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
358336
# The extra values given here take precedence over values defined on the client or passed to this method.
359337
extra_headers: Headers | None = None,
@@ -369,14 +347,6 @@ async def create(
369347
Args:
370348
zone_id: Identifier
371349
372-
action: The action to take when the expression matches.
373-
374-
expression: Criteria defining when there is a match for the current rule.
375-
376-
description: The description of the rule.
377-
378-
enabled: When set to true, the rule is enabled.
379-
380350
extra_headers: Send extra headers
381351
382352
extra_query: Add additional query parameters to the request
@@ -391,15 +361,7 @@ async def create(
391361
raise ValueError(f"Expected a non-empty value for `waiting_room_id` but received {waiting_room_id!r}")
392362
return await self._post(
393363
f"/zones/{zone_id}/waiting_rooms/{waiting_room_id}/rules",
394-
body=await async_maybe_transform(
395-
{
396-
"action": action,
397-
"expression": expression,
398-
"description": description,
399-
"enabled": enabled,
400-
},
401-
rule_create_params.RuleCreateParams,
402-
),
364+
body=await async_maybe_transform(rules, rule_create_params.RuleCreateParams),
403365
options=make_request_options(
404366
extra_headers=extra_headers,
405367
extra_query=extra_query,
@@ -415,7 +377,7 @@ async def update(
415377
waiting_room_id: str,
416378
*,
417379
zone_id: str,
418-
body: Iterable[rule_update_params.Body],
380+
rules: Iterable[rule_update_params.Rule],
419381
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
420382
# The extra values given here take precedence over values defined on the client or passed to this method.
421383
extra_headers: Headers | None = None,
@@ -445,7 +407,7 @@ async def update(
445407
raise ValueError(f"Expected a non-empty value for `waiting_room_id` but received {waiting_room_id!r}")
446408
return await self._put(
447409
f"/zones/{zone_id}/waiting_rooms/{waiting_room_id}/rules",
448-
body=await async_maybe_transform(body, Iterable[rule_update_params.Body]),
410+
body=await async_maybe_transform(rules, Iterable[rule_update_params.Rule]),
449411
options=make_request_options(
450412
extra_headers=extra_headers,
451413
extra_query=extra_query,

src/cloudflare/types/waiting_rooms/rule_create_params.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,17 @@
44

55
from typing_extensions import Literal, Required, TypedDict
66

7-
__all__ = ["RuleCreateParams"]
7+
__all__ = ["RuleCreateParams", "Rules"]
88

99

1010
class RuleCreateParams(TypedDict, total=False):
1111
zone_id: Required[str]
1212
"""Identifier"""
1313

14+
rules: Required[Rules]
15+
16+
17+
class Rules(TypedDict, total=False):
1418
action: Required[Literal["bypass_waiting_room"]]
1519
"""The action to take when the expression matches."""
1620

src/cloudflare/types/waiting_rooms/rule_update_params.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@
55
from typing import Iterable
66
from typing_extensions import Literal, Required, TypedDict
77

8-
__all__ = ["RuleUpdateParams", "Body"]
8+
__all__ = ["RuleUpdateParams", "Rule"]
99

1010

1111
class RuleUpdateParams(TypedDict, total=False):
1212
zone_id: Required[str]
1313
"""Identifier"""
1414

15-
body: Required[Iterable[Body]]
15+
rules: Required[Iterable[Rule]]
1616

1717

18-
class Body(TypedDict, total=False):
18+
class Rule(TypedDict, total=False):
1919
action: Required[Literal["bypass_waiting_room"]]
2020
"""The action to take when the expression matches."""
2121

0 commit comments

Comments
 (0)