Skip to content

Commit 36726d6

Browse files
mbpEsen Sagynov
mbp
and
Esen Sagynov
authored
Upgrade nodejs runtime to 16.x (v2 branch) (#184)
* Upgrade to aws-cdk-lib 2.28.0 which includes support for NODEJS_16_X in CustomResourceProviderRuntime * Upgrade all code to use NODEJS_16_X instead of NODEJS_14_X. * Upgrade all code to use NODEJS_16_X instead of NODEJS_12_X. * Updated top level dependencies. - Updated Lerna to the latest version. - Updated Webpack dependency in cdkdx which has an SSL security issue hupe1980/cdkdx#22. - Updated ClamAV version for Ubuntu run in Docker. Version `0.103.11-1.el7` is no longer available. - Added build instructions to README. * Use Node v18 and v20 for build. Versions 14 and 16 are EOL as of 2024. * Grant permission to access Docker socket. Docker is required to build some of the packages. Must grant permissions to the socket. * Specify the exact tag because `latest` is unavailable. - Issue reported in aws/jsii#3505. - Upstream https://hub.docker.com/r/jsii/superchain recommends the `1-bullseye-slim` version. Build results: ``` Lerna (powered by Nx) Successfully ran target build for 45 projects (2m) ✨ Done in 113.17s. ``` Test results: ``` Test Suites: 42 passed, 42 total Tests: 106 passed, 106 total Snapshots: 64 passed, 64 total Time: 7.664 s Ran all test suites in 27 projects. ✨ Done in 10.13s. ``` Co-authored-by: Esen Sagynov <[email protected]>
1 parent 9970609 commit 36726d6

File tree

99 files changed

+1020
-826
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

99 files changed

+1020
-826
lines changed

‎.vscode/settings.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"eslint.alwaysShowStatus": true,
33
"editor.codeActionsOnSave": {
4-
"source.fixAll.eslint": true
4+
"source.fixAll.eslint": "explicit"
55
},
66
"explorer.autoReveal": false
77
}

‎examples/blue-green-container-deployment-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
"dependencies": {
1212
"@cloudcomponents/cdk-blue-green-container-deployment": "^2.1.0",
1313
"@cloudcomponents/cdk-container-registry": "^2.1.0",
14-
"aws-cdk-lib": "2.8.0",
14+
"aws-cdk-lib": "^2.28.0",
1515
"constructs": "10.0.41",
1616
"source-map-support": "^0.5.21"
1717
},
1818
"devDependencies": {
1919
"@types/source-map-support": "^0.5.4",
20-
"aws-cdk": "2.8.0"
20+
"aws-cdk": "^2.28.0"
2121
}
2222
}

‎examples/cloudfront-authorization-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-cloudfront-authorization": "^2.1.0",
13-
"aws-cdk-lib": "^2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "^10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎examples/codecommit-backup-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-codecommit-backup": "^2.0.0",
13-
"aws-cdk-lib": "^2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "^10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎examples/codepipeline-check-parameter-action-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-codepipeline-check-parameter-action": "^2.1.0",
13-
"aws-cdk-lib": "2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎examples/codepipeline-merge-action-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
},
1212
"dependencies": {
1313
"@cloudcomponents/cdk-codepipeline-merge-action": "^2.1.0",
14-
"aws-cdk-lib": "2.8.0",
14+
"aws-cdk-lib": "^2.28.0",
1515
"constructs": "10.0.41",
1616
"source-map-support": "^0.5.21"
1717
},
1818
"devDependencies": {
1919
"@types/source-map-support": "^0.5.4",
20-
"aws-cdk": "2.8.0"
20+
"aws-cdk": "^2.28.0"
2121
}
2222
}

‎examples/codepipeline-slack-approval-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-codepipeline-slack": "^2.1.0",
13-
"aws-cdk-lib": "2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎examples/container-audit-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
"dependencies": {
1212
"@cloudcomponents/cdk-codepipeline-anchore-inline-scan-action": "^2.1.0",
1313
"@cloudcomponents/cdk-codepipeline-dockerfile-linter-action": "^2.1.0",
14-
"aws-cdk-lib": "2.8.0",
14+
"aws-cdk-lib": "^2.28.0",
1515
"constructs": "10.0.41",
1616
"source-map-support": "^0.5.21"
1717
},
1818
"devDependencies": {
1919
"@types/source-map-support": "^0.5.4",
20-
"aws-cdk": "2.8.0"
20+
"aws-cdk": "^2.28.0"
2121
}
2222
}

‎examples/contentful-webhook-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
"dependencies": {
1212
"@cloudcomponents/cdk-contentful-webhook": "^2.1.0",
1313
"@cloudcomponents/cdk-secret-key": "^2.0.0",
14-
"aws-cdk-lib": "^2.8.0",
14+
"aws-cdk-lib": "^2.28.0",
1515
"constructs": "^10.0.41",
1616
"source-map-support": "^0.5.21"
1717
},
1818
"devDependencies": {
1919
"@types/source-map-support": "^0.5.4",
20-
"aws-cdk": "2.8.0"
20+
"aws-cdk": "^2.28.0"
2121
}
2222
}

‎examples/dependency-check-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-dependency-check": "^2.1.0",
13-
"aws-cdk-lib": "2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎examples/dynamodb-seeder-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-dynamodb-seeder": "^2.1.0",
13-
"aws-cdk-lib": "^2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "^10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎examples/github-webhook-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
"dependencies": {
1212
"@cloudcomponents/cdk-github-webhook": "^2.1.0",
1313
"@cloudcomponents/cdk-secret-key": "^2.0.0",
14-
"aws-cdk-lib": "2.8.0",
14+
"aws-cdk-lib": "^2.28.0",
1515
"constructs": "10.0.41",
1616
"source-map-support": "^0.5.21"
1717
},
1818
"devDependencies": {
1919
"@types/source-map-support": "^0.5.4",
20-
"aws-cdk": "2.8.0"
20+
"aws-cdk": "^2.28.0"
2121
}
2222
}

‎examples/notifications-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
"dependencies": {
1212
"@cloudcomponents/cdk-chatops": "^2.1.0",
1313
"@cloudcomponents/cdk-developer-tools-notifications": "^2.1.0",
14-
"aws-cdk-lib": "2.8.0",
14+
"aws-cdk-lib": "^2.28.0",
1515
"constructs": "10.0.41",
1616
"source-map-support": "^0.5.21"
1717
},
1818
"devDependencies": {
1919
"@types/source-map-support": "^0.5.4",
20-
"aws-cdk": "2.8.0"
20+
"aws-cdk": "^2.28.0"
2121
}
2222
}

‎examples/pull-request-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
"dependencies": {
1212
"@cloudcomponents/cdk-pull-request-approval-rule": "^2.1.0",
1313
"@cloudcomponents/cdk-pull-request-check": "^2.1.0",
14-
"aws-cdk-lib": "^2.8.0",
14+
"aws-cdk-lib": "^2.28.0",
1515
"constructs": "^10.0.41",
1616
"source-map-support": "^0.5.21"
1717
},
1818
"devDependencies": {
1919
"@types/source-map-support": "^0.5.4",
20-
"aws-cdk": "2.8.0"
20+
"aws-cdk": "^2.28.0"
2121
}
2222
}

‎examples/responsive-email-template-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-responsive-email-template": "^2.1.0",
13-
"aws-cdk-lib": "2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎examples/s3-antivurs-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-s3-antivirus": "^2.1.0",
13-
"aws-cdk-lib": "2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎examples/static-website-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-static-website": "^2.0.0",
13-
"aws-cdk-lib": "^2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "^10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎examples/stripe-webhook-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
"dependencies": {
1212
"@cloudcomponents/cdk-secret-key": "^2.0.0",
1313
"@cloudcomponents/cdk-stripe-webhook": "^2.1.0",
14-
"aws-cdk-lib": "2.8.0",
14+
"aws-cdk-lib": "^2.28.0",
1515
"constructs": "10.0.41",
1616
"source-map-support": "^0.5.21"
1717
},
1818
"devDependencies": {
1919
"@types/source-map-support": "^0.5.4",
20-
"aws-cdk": "2.8.0"
20+
"aws-cdk": "^2.28.0"
2121
}
2222
}

‎examples/temp-stack-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-temp-stack": "^2.1.0",
13-
"aws-cdk-lib": "^2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "^10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎examples/wordpress-example/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
},
1111
"dependencies": {
1212
"@cloudcomponents/cdk-wordpress": "^2.0.0",
13-
"aws-cdk-lib": "^2.8.0",
13+
"aws-cdk-lib": "^2.28.0",
1414
"constructs": "^10.0.41",
1515
"source-map-support": "^0.5.21"
1616
},
1717
"devDependencies": {
1818
"@types/source-map-support": "^0.5.4",
19-
"aws-cdk": "2.8.0"
19+
"aws-cdk": "^2.28.0"
2020
}
2121
}

‎packages/cdk-blue-green-container-deployment/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,12 @@
6161
}
6262
},
6363
"peerDependencies": {
64-
"aws-cdk-lib": "^2.8.0",
64+
"aws-cdk-lib": "^2.28.0",
6565
"constructs": "^10.0.41"
6666
},
6767
"devDependencies": {
68-
"@aws-cdk/assert": "2.8.0",
69-
"aws-cdk-lib": "2.8.0",
68+
"@aws-cdk/assert": "2.28.0",
69+
"aws-cdk-lib": "^2.28.0",
7070
"aws-sdk": "^2.1096.0",
7171
"constructs": "10.0.41",
7272
"custom-resource-helper": "^1.0.15",

‎packages/cdk-blue-green-container-deployment/src/__tests__/__snapshots__/dummy-task-definition.test.ts.snap

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Object {
1616
"Arn",
1717
],
1818
},
19-
"Runtime": "nodejs12.x",
19+
"Runtime": "nodejs18.x",
2020
"Timeout": 120,
2121
},
2222
"Type": "AWS::Lambda::Function",

‎packages/cdk-blue-green-container-deployment/src/__tests__/ecs-deployment-group.test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ describe('EcsDeploymentConfig', () => {
9494
const { service, prodTargetGroup, testTargetGroup, prodListener, testListener } = createPrereqResources(stack);
9595

9696
const customApplication = new codedeploy.EcsApplication(stack, 'CustomApplication', {
97-
applicationName: 'My Custom Application',
97+
applicationName: 'My-Custom-Application',
9898
});
9999

100100
new EcsDeploymentGroup(stack, 'DeploymentGroup', {
@@ -110,7 +110,7 @@ describe('EcsDeploymentConfig', () => {
110110
expectCDK(stack).to(
111111
haveResource('AWS::CodeDeploy::Application', {
112112
ComputePlatform: 'ECS',
113-
ApplicationName: 'My Custom Application',
113+
ApplicationName: 'My-Custom-Application',
114114
}),
115115
);
116116

@@ -129,7 +129,7 @@ describe('EcsDeploymentConfig', () => {
129129
const { service, prodTargetGroup, testTargetGroup, prodListener, testListener } = createPrereqResources(stack);
130130

131131
new EcsDeploymentGroup(stack, 'DeploymentGroup', {
132-
applicationName: 'My Named Application',
132+
applicationName: 'My-Named-Application',
133133
deploymentGroupName: 'My Deployment Group',
134134
ecsServices: [service],
135135
targetGroups: [prodTargetGroup, testTargetGroup],
@@ -141,7 +141,7 @@ describe('EcsDeploymentConfig', () => {
141141
expectCDK(stack).to(
142142
haveResource('AWS::CodeDeploy::Application', {
143143
ComputePlatform: 'ECS',
144-
ApplicationName: 'My Named Application',
144+
ApplicationName: 'My-Named-Application',
145145
}),
146146
);
147147

‎packages/cdk-blue-green-container-deployment/src/ecs-deployment-group.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ export class EcsDeploymentGroup extends Resource implements IEcsDeploymentGroup,
129129
}
130130

131131
const serviceToken = new Function(this, 'Function', {
132-
runtime: Runtime.NODEJS_14_X,
132+
runtime: Runtime.NODEJS_16_X,
133133
code: Code.fromAsset(path.join(__dirname, 'lambdas', 'ecs-deployment-group')),
134134
handler: 'index.handler',
135135
timeout: Duration.minutes(15),

‎packages/cdk-blue-green-container-deployment/src/ecs-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export class EcsService extends Construct implements IConnectable, IEcsService,
103103
];
104104

105105
const serviceToken = new Function(this, 'Function', {
106-
runtime: Runtime.NODEJS_14_X,
106+
runtime: Runtime.NODEJS_16_X,
107107
code: Code.fromAsset(path.join(__dirname, 'lambdas', 'ecs-service')),
108108
handler: 'index.handler',
109109
timeout: Duration.minutes(15),

‎packages/cdk-chatops/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@
6060
}
6161
},
6262
"peerDependencies": {
63-
"aws-cdk-lib": "^2.8.0",
63+
"aws-cdk-lib": "^2.28.0",
6464
"constructs": "^10.0.41"
6565
},
6666
"devDependencies": {
67-
"@aws-cdk/assert": "2.8.0",
68-
"aws-cdk-lib": "2.8.0",
67+
"@aws-cdk/assert": "2.28.0",
68+
"aws-cdk-lib": "^2.28.0",
6969
"aws-sdk": "^2.1096.0",
7070
"axios": "^0.25.0",
7171
"constructs": "10.0.41",

‎packages/cdk-chatops/src/msteams-incoming-webhook-configuration.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export class MSTeamsIncomingWebhookConfiguration extends Construct {
3636
super(scope, id);
3737

3838
this.incomingWebhook = new Function(this, 'Function', {
39-
runtime: Runtime.NODEJS_14_X,
39+
runtime: Runtime.NODEJS_16_X,
4040
code: Code.fromAsset(path.join(__dirname, 'lambdas', 'msteams-incoming-webhook')),
4141
handler: 'index.handler',
4242
environment: {

0 commit comments

Comments
 (0)