Fix package nickname coercion

Bike · Bike · commit fcfd70bf1fed · 2024-06-24T16:05:07.000-04:00
diff --git a/src/core/lisp.cc b/src/core/lisp.cc
@@ -941,7 +941,7 @@ Package_sp Lisp::makePackage(SimpleString_sp name, List_sp nicknames, List_sp us
       this->_Roots._Packages.push_back(newPackage);
     }
     // Assign nicknames.
-    for (auto nc : nicknames) {
+    for (auto nc : cnicknames) {
       this->_Roots._PackageNameIndexMap->setf_gethash(oCar(nc), packageIndex);
     }
     newPackage->setNicknames(cnicknames);

Original file line number	Diff line number	Diff line change
`@@ -941,7 +941,7 @@ Package_sp Lisp::makePackage(SimpleString_sp name, List_sp nicknames, List_sp us`
`941`	`941`	`this->_Roots._Packages.push_back(newPackage);`
`942`	`942`	`}`
`943`	`943`	`// Assign nicknames.`
`944`		`- for (auto nc : nicknames) {`
	`944`	`+ for (auto nc : cnicknames) {`
`945`	`945`	`this->_Roots._PackageNameIndexMap->setf_gethash(oCar(nc), packageIndex);`
`946`	`946`	`}`
`947`	`947`	`newPackage->setNicknames(cnicknames);`