Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Commit c46072b

Browse files
authored
Merge pull request #330 from ckeditor/t/ckeditor5-image/310
Other: Improved the resizer performance. Closes ckeditor/ckeditor5#5191.
2 parents b99cb16 + a15e79a commit c46072b

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

tests/imageresize.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ describe( 'ImageResize', () => {
131131
it( 'disables the resizer if the command is disabled', () => {
132132
setData( editor.model, `<paragraph>foo</paragraph>[<image src="${ IMAGE_SRC_FIXTURE }"></image>]` );
133133

134-
const resizer = editor.plugins.get( 'WidgetResize' ).resizers[ 0 ];
134+
const resizer = getSelectedImageResizer( editor );
135135

136136
let isEnabled = false;
137137

@@ -161,7 +161,7 @@ describe( 'ImageResize', () => {
161161
editor.model.insertContent( writer.createElement( 'image', { src: IMAGE_SRC_FIXTURE } ) );
162162
} );
163163

164-
const resizer = editor.plugins.get( 'WidgetResize' ).resizers[ 0 ];
164+
const resizer = getSelectedImageResizer( editor );
165165
const resizerWrapper = editor.ui.getEditableElement().querySelector( '.ck-widget__resizer' );
166166

167167
expect( resizer.isEnabled ).to.be.false;
@@ -521,7 +521,7 @@ describe( 'ImageResize', () => {
521521

522522
editor.commands.get( 'undo' ).execute();
523523

524-
await wait( 40 );
524+
await wait( 160 ); // ui#update event is throttled.
525525

526526
const resizerWrapper = document.querySelector( '.ck-widget__resizer' );
527527
const shadowBoundingRect = resizerWrapper.getBoundingClientRect();
@@ -668,7 +668,7 @@ describe( 'ImageResize', () => {
668668
it( 'hides the resize wrapper when its disabled', () => {
669669
setData( editor.model, `<paragraph>foo</paragraph>[<image src="${ IMAGE_SRC_FIXTURE }"></image>]` );
670670

671-
const resizer = editor.plugins.get( 'WidgetResize' ).resizers[ 0 ];
671+
const resizer = getSelectedImageResizer( editor );
672672
const resizerWrapper = editor.ui.getEditableElement().querySelector( '.ck-widget__resizer' );
673673

674674
expect( resizerWrapper.style.display ).to.equal( '' );
@@ -771,6 +771,12 @@ describe( 'ImageResize', () => {
771771
editor.ui.focusTracker.isFocused = true;
772772
}
773773

774+
function getSelectedImageResizer( editor ) {
775+
return editor.plugins.get( 'WidgetResize' )._getResizerByViewElement(
776+
editor.editing.view.document.selection.getSelectedElement()
777+
);
778+
}
779+
774780
function createEditor( config ) {
775781
editorElement = document.createElement( 'div' );
776782

0 commit comments

Comments
 (0)