Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Commit 6c74d59

Browse files
authored
Merge pull request #303 from ckeditor/t/ckeditor5/1403
Fix: The UI buttons should be marked as toggleable for better assistive technologies support (see ckeditor/ckeditor5#1403).
2 parents fa6b240 + 221a496 commit 6c74d59

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/imagestyle/imagestyleui.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ export default class ImageStyleUI extends Plugin {
8585
view.set( {
8686
label: style.title,
8787
icon: style.icon,
88-
tooltip: true
88+
tooltip: true,
89+
isToggleable: true
8990
} );
9091

9192
view.bind( 'isEnabled' ).to( command, 'isEnabled' );

tests/imagestyle/imagestyleui.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ describe( 'ImageStyleUI', () => {
5656
expect( buttonView ).to.be.instanceOf( ButtonView );
5757
expect( buttonView.label ).to.equal( style.title );
5858
expect( buttonView.icon ).to.equal( style.icon );
59+
expect( buttonView.isToggleable ).to.be.true;
5960

6061
command.isEnabled = true;
6162
expect( buttonView.isEnabled ).to.be.true;

0 commit comments

Comments
 (0)