Skip to content

The upcast element to attribute fails to convert when upcastAlso is defined as a function #4534

Closed
ckeditor/ckeditor5-engine
#1787
@jodator

Description

@jodator

Found out after ckeditor/ckeditor5-basic-styles#94 got merged. The prepareToAttribute() converter exits when in a config.view only a name of an element was defined. That check didn't account for the possibility of a function being provided. This would wrongly mark such definitions as with an only name defined and wasn't converting an attribute properly.

This fix is simple and only needs some tests to be written.

Metadata

Metadata

Assignees

Labels

package:enginetype:bugThis issue reports a buggy (incorrect) behavior.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions