Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KaiCode 2024 Reviewer Comments #51

Open
citrusvanilla opened this issue Jul 19, 2024 · 1 comment
Open

KaiCode 2024 Reviewer Comments #51

citrusvanilla opened this issue Jul 19, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@citrusvanilla
Copy link
Owner

citrusvanilla commented Jul 19, 2024 •
edited
Loading

TinyFlux was reviewed by the KaiCode 2024 panel of developers, who provided the following potential improvements for the project:

Complex Source Files
Several files do exceed reasonable limits and could be their own modules, or collections of scripts:

  • database.py (1619 lines)
  • index.py (932 lines)
  • queries.py (875 lines)

No CI on PRs
The GitHub Actions script in .github can be updated to utilize CI on PRs.

Long Test Function Bodies
While there is 100% coverage, many tests have too many assertions in them:

  • test_point.py
  • test_measurement.py
  • test_index.py
@citrusvanilla citrusvanilla added the good first issue Good for newcomers label Jul 19, 2024
@Aminmalek
Copy link

I can work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@citrusvanilla @Aminmalek