Fix: coerce "kid" during lookup (#116)

Fixes #109

* Number typed "kid", coerce to string

* target all non-strings instead of only numbers

Author: panva

lib/jwk/keystore.js

@@ -395,6 +395,11 @@ var JWKStore = function(registry, parent) {
     value: function(props, local) {
       props = props || {};
 
+      // workaround for issues/109
+      if (props.kid !== undefined && props.kid !== null && typeof props.kid !== "string") {
+        props.kid = String(props.kid);
+      }
+
       var candidates = [];
       var matches = function(key) {
         // match on 'kty'
@@ -476,6 +481,11 @@ var JWKStore = function(registry, parent) {
         props.kid = kid;
       }
 
+      // workaround for issues/109
+      if (props.kid !== undefined && props.kid !== null && typeof props.kid !== "string") {
+       props.kid = String(props.kid);
+      }
+
       var candidates = this.all(props, true);
       if (!candidates.length && parent && !local) {
         candidates = parent.get(props, local);

test/jwk/keystore-test.js

@@ -386,6 +386,28 @@ describe("jwk/keystore", function() {
 
   describe("query", function() {
     // TODO: testit!
+
+    it("handles (albeit off-spec) number kids", function() {
+      var promise = JWK.store.KeyStore.asKeyStore({
+        keys: [
+          {
+             kty: 'RSA',
+             alg: 'RS256',
+             use: 'sig',
+             n: 'zi9ox5mVK1nS6rASj5VwTqsozmyoHcqOuf2LLvuNzijPx7ybASzUerP-QZCYL3EC66TtmO2T2fxEyfrK0r7OpsJ3QYlZZ4rHm7s_mFc9upxjnTZ-ElJJsAxWhuBZyZTpzfXT7lTm4QN0QZgy3ydmv4W4RFh2tzAZ4wKc4ruoI-SIVSiZZZ_R3-zhu6zu2JfRc6Vt6MapLfgNtaVuzKWeuCC-42-4vngf2TYqJLlRvrywNJ1qtf-dUpB5UutJUIPBeDrVmoJPC7H8cdbOxSV3b4y8cvn0aQQouO3vQGyNg-LA0D-NGuSW-nEOyfuUR0skcUh6VIhEpcw8iF8nJ1X7yQ',
+             e: 'AQAB',
+             kid: 1
+           }
+        ]
+      });
+
+      promise = promise.then(function (keystore) {
+        assert.ok(keystore.get({ kid: 1 }));
+        assert.equal(keystore.all({ kid: 1 }).length, 1);
+      });
+
+      return promise;
+    });
   });
 
   describe("export", function() {