Fix: fix throws and rejects to be error objects and consistent

Author: linuxwolf

lib/algorithms/concat.js

@@ -20,7 +20,7 @@ function concatDeriveFn(name) {
     var keyLen = props.length,
         hashLen = CONSTANTS.HASHLENGTH[name];
     if (!keyLen) {
-      return Promise.reject("invalid key length");
+      return Promise.reject(new Error("invalid key length"));
     }
 
     // setup otherInfo

lib/algorithms/hmac.js

@@ -151,7 +151,7 @@ function hmacVerifyFN(name) {
     }
     promise = promise.then(function(result) {
       if (!result) {
-        return Promise.reject("verifaction failed");
+        return Promise.reject(new Error("verifaction failed"));
       }
 
       return {

lib/jwe/encrypt.js

@@ -148,7 +148,7 @@ function JWEEncrypter(cfg, fields, recipients) {
   Object.defineProperty(this, "final", {
     value: function(data, encoding) {
       if (finalized) {
-        throw new Error("already final");
+        return Promise.reject(new Error("already final"));
       }
 
       // last-minute data

lib/jwk/keystore.js

@@ -593,7 +593,7 @@ JWKStore.asKeyStore = function(ks) {
   } else if ("keys" in ks) {
     keys = ks.keys;
   } else {
-    return Promise.reject("invalid keystore");
+    return Promise.reject(new Error("invalid keystore"));
   }
 
   keys = keys.map(function(k) {

lib/jws/sign.js

@@ -98,7 +98,7 @@ var JWSSigner = function(cfg, signatories) {
   Object.defineProperty(this, "final", {
     value: function(data, encoding) {
       if (finalized) {
-        throw new Error("already final");
+        return Promise.reject(new Error("already final"));
       }
 
       // last-minute data

lib/jws/verify.js

@@ -99,7 +99,7 @@ var JWSVerifier = function(ks) {
                                        content,
                                        sig.signature);
           } else {
-            algPromise = Promise.reject("key does not match");
+            algPromise = Promise.reject(new Error("key does not match"));
           }
           algPromise = algPromise.then(function(result) {
             var payload = result.data.toString("ascii");