Skip to content

Commit 9dce360

Browse files
committed
Ensure that setuptools>=71 is not installed
gophish requires six==1.15.0, whereas setuptools>=71 requires six==1.16.0. The installation of setuptools>=71 ends up being a problem when attempting to reinstall this package, since then setuptools cannot be imported. This is precisely what happens during idempotence testing of cisagov/ansible-role-pca-gophish-composition, so we must insist that only setuptools<71 is installed.
1 parent 7f14282 commit 9dce360

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

setup.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,13 @@ def get_version(version_file):
9393
package_dir={"": "src"},
9494
py_modules=[splitext(basename(path))[0] for path in glob("src/*.py")],
9595
include_package_data=True,
96-
install_requires=["docopt", "gophish", "setuptools >= 24.2.0"],
96+
# gophish requires six==1.15.0, whereas setuptools>=71 requires
97+
# six==1.16.0. The installation of setuptools>=71 ends up being a problem
98+
# when attempting to reinstall this package, since then setuptools cannot
99+
# be imported. This is precisely what happens during idempotence testing
100+
# of cisagov/ansible-role-pca-gophish-composition, so we must insist that
101+
# only setuptools<71 is installed.
102+
install_requires=["docopt", "gophish", "setuptools >=24.2.0,<71"],
97103
extras_require={
98104
"test": [
99105
"coverage",

0 commit comments

Comments
 (0)