Skip to content

Commit 14783b0

Browse files
mmistakeschukycheese
authored andcommitted
Remove tabindex="-1" from input elements in search.html layout
Make `input` elements accessible by keyboard. Fixes mmistakes#2982
1 parent 2e7e0ca commit 14783b0

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
### Bug Fixes
44

5+
- Remove `tabindex="-1"` from `input` elements in `search.html` layout to allow them to be accessible by keyboard. [#2982](https://github.com/mmistakes/minimal-mistakes/issues/2982)
56
- Fix broken sidebar image in sample post. [#3013](https://github.com/mmistakes/minimal-mistakes/issues/3013)
67
- Fix broken links in Upgrading documentation. [#3004](https://github.com/mmistakes/minimal-mistakes/issues/3004)
78

_layouts/search.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ <h1 id="page-title" class="page__title">{{ page.title }}</h1>
2525
{%- assign search_provider = site.search_provider | default: "lunr" -%}
2626
{%- case search_provider -%}
2727
{%- when "lunr" -%}
28-
<input type="text" id="search" class="search-input" tabindex="-1" placeholder="{{ site.data.ui-text[site.locale].search_placeholder_text | default: 'Enter your search term...' }}" />
28+
<input type="text" id="search" class="search-input" placeholder="{{ site.data.ui-text[site.locale].search_placeholder_text | default: 'Enter your search term...' }}" />
2929
<div id="results" class="results"></div>
3030
{%- when "google" -%}
3131
<form onsubmit="return googleCustomSearchExecute();" id="cse-search-box-form-id">
32-
<input type="text" id="cse-search-input-box-id" class="search-input" tabindex="-1" placeholder="{{ site.data.ui-text[site.locale].search_placeholder_text | default: 'Enter your search term...' }}" />
32+
<input type="text" id="cse-search-input-box-id" class="search-input" placeholder="{{ site.data.ui-text[site.locale].search_placeholder_text | default: 'Enter your search term...' }}" />
3333
</form>
3434
<div id="results" class="results">
3535
<gcse:searchresults-only></gcse:searchresults-only>

docs/_docs/18-history.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,15 @@ permalink: /docs/history/
55
excerpt: "Change log of enhancements and bug fixes made to the theme."
66
sidebar:
77
nav: docs
8-
last_modified_at: 2021-06-23T08:17:10-04:00
8+
last_modified_at: 2021-06-23T08:26:21-04:00
99
toc: false
1010
---
1111

1212
## Unreleased
1313

1414
### Bug Fixes
1515

16+
- Remove `tabindex="-1"` from `input` elements in `search.html` layout to allow them to be accessible by keyboard. [#2982](https://github.com/mmistakes/minimal-mistakes/issues/2982)
1617
- Fix broken sidebar image in sample post. [#3013](https://github.com/mmistakes/minimal-mistakes/issues/3013)
1718
- Fix broken links in Upgrading documentation. [#3004](https://github.com/mmistakes/minimal-mistakes/issues/3004)
1819

0 commit comments

Comments
 (0)