Skip to content

Commit b7e5304

Browse files
fix: default in attr ensures default values
* no need for explicit assigns https://hexdocs.pm/phoenix_live_view/Phoenix.Component.html#attr/3-options
1 parent b2ec37f commit b7e5304

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

lib/bloom/components/marquee.ex

-7
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,6 @@ defmodule Bloom.Components.Marquee do
4242
slot(:inner_block, required: true)
4343

4444
def marquee(assigns) do
45-
assigns =
46-
assigns
47-
|> assign(:repeat, assigns[:repeat] || 4)
48-
|> assign(:vertical, assigns[:vertical] || false)
49-
|> assign(:pause_on_hover, assigns[:pause_on_hover] || false)
50-
|> assign(:reverse, assigns[:reverse] || false)
51-
5245
~H"""
5346
<div
5447
:if={@repeat > 0}

priv/templates/marquee.ex

-7
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,6 @@ defmodule <%= @module_name %>Web.Components.Marquee do
4242
slot(:inner_block, required: true)
4343

4444
def marquee(assigns) do
45-
assigns =
46-
assigns
47-
|> assign(:repeat, assigns[:repeat] || 4)
48-
|> assign(:vertical, assigns[:vertical] || false)
49-
|> assign(:pause_on_hover, assigns[:pause_on_hover] || false)
50-
|> assign(:reverse, assigns[:reverse] || false)
51-
5245
~H"""
5346
<div
5447
:if={@repeat > 0}

0 commit comments

Comments
 (0)