-
Notifications
You must be signed in to change notification settings - Fork 89
Use winrm v2 implementation #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Encodes the script so that it can be passed to the PowerShell | ||
# --EncodedCommand argument. | ||
# @return [String] The UTF-16LE base64 encoded script | ||
def encoded(script) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I like the approach to make this more explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Also, there is no PowershellScript
class in winrm v2 so we cant leverage that.
This looks awesome @mwrock Is this also addressing the issue, where we are only able to transfer scripts with a limited size? |
Thats right. There will be no script length limitation and according to local benchmarking, file uploads will be 15-30x faster. You can also run scripts within the same scope. So you could do:
Previously the second And winrmV2 can talk to and transfer files to Windows Nano server. |
Created a separate PR for the travis/appveyor changes #123 |
No longer WIP :) |
💯 @mwrock |
Test-Kitchen using winrm v2 has just been released. I'll be removing the WIP from kitchen-inspec momentarily as well.