Add a generic rspec module, and use and test it via the generator script. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| include_context "run with driver", :driver_string => "#{snake_name}" | ||
|
|
||
| with_chef_server do |
There was a problem hiding this comment.
Does this need to be the when_the_chef_12_server like we have in all the AWS tests? I like with_chef_server much better but I am curious about what the switch means
There was a problem hiding this comment.
Nope, with_chef_server actually calls when_the_chef_12_server, but
- with a clearer name, and
- with default values.
All the chef-provisioning-aws invocations look like
when_the_chef_12_server "exists", organization: 'foo', server_scope: :context
and this encapsulates (overridable) defaults
organization: "spec_tests", server_scope: :context, port: 8900..9000
|
This is awesome. I have 1 question but I am 👍 on this and you can merge it |
randomcamel
force-pushed
the
cd/generic-specs
branch
from
6a83773 to
f2e2713
Compare
… can include to easily load the driver for testing. - Wrap 'when_the_chef_12_server' in 'with_chef_server' with common defaults (which can be overridden). - Rake tasks to automate testing the driver generator and specs. - Add required version restrictions in the generated Gemfile. - Add some basic reality-checking specs to the generated driver, including a loading a new no-op resource in the new driver. - Add 'rake cycle' to Travis to run the whole generate-test sequence.
randomcamel
force-pushed
the
cd/generic-specs
branch
from
f2e2713 to
911180c
Compare
randomcamel
added a commit
that referenced
this pull request
Aug 10, 2015
Add a generic rspec module, and use and test it via the generator script.
randomcamel
added a commit
that referenced
this pull request
Aug 19, 2015
Add a generic rspec module, and use and test it via the generator script.
bglimepoint
pushed a commit
to bglimepoint/chef-provisioning
that referenced
this pull request
Oct 29, 2018
Add a generic rspec module, and use and test it via the generator script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.