linux-next: Error (fsnotify.c:486): fsnotify: Can't add watch for 0x3 with 0x1: Invalid argument

[avagin]

11:55:43 Dump log   : /root/criu/test/dump/static/inotify00/48/1/dump.log
11:55:43 --------------------------------- grep Error ---------------------------------
11:55:43 ------------------------------------- END -------------------------------------
11:55:43 Restore log: /root/criu/test/dump/static/inotify00/48/1/restore.log
11:55:43 --------------------------------- grep Error ---------------------------------
11:55:43 (00.000167) Error (sysctl.c:142): Can't open sysctl net/ipv4/tcp_rmem: No such file or directory
11:55:43 (00.005886)     48: Error (fsnotify.c:486): fsnotify: Can't add watch for 0x3 with 0x1: Invalid argument
11:55:43 (00.006307) Error (cr-restore.c:1234): 48 exited, status=1
11:55:43 (00.006335) Error (cr-restore.c:1933): Restoring FAILED.
11:55:43 ------------------------------------- END -------------------------------------

[avagin]

/* This inode cares about things that happen to its children.  Always set for
 * dnotify and inotify. */
#define FS_EVENT_ON_CHILD       0x08000000

[xemul]

Fixed in the kernel.

[xemul]

Fixed in the kernel.

[avagin]

You are not able to restore processes which were dumped on old kernels, because inotify masks contains this extra bit.

[xemul]

What's the kernel version(s) on which this bit is shown in /proc? My impression was that it was accidentally broken in some -rc and got fixed quite fast. Am I wrong?

[avagin]

Yes, you are wrong. It has been shown that for a long time. It works, because Inotify_add_watch didn't care about extra bits. Recently it started to check a mask and we found this extra bit in fdinfo.

[xemul]

I see.

[xemul]

61859d1