Skip to content

Commit 40ed330

Browse files
Cyrill Gorcunovxemul
Cyrill Gorcunov
authored andcommitted
kcmp: Stop showing ids tree
Useless, at least in the form present now it's unreadable anyway. So stop welling out the logs. Signed-off-by: Cyrill Gorcunov <[email protected]> Signed-off-by: Pavel Emelyanov <[email protected]>
1 parent db70a41 commit 40ed330

File tree

5 files changed

+0
-61
lines changed

5 files changed

+0
-61
lines changed

cr-dump.c

-1
Original file line numberDiff line numberDiff line change
@@ -1546,7 +1546,6 @@ int cr_dump_tasks(pid_t pid)
15461546
if (ret)
15471547
goto err;
15481548

1549-
fd_id_show_tree();
15501549
err:
15511550
if (disconnect_from_page_server())
15521551
ret = -1;

file-ids.c

-5
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@
2222

2323
static DECLARE_KCMP_TREE(fd_tree, KCMP_FILE);
2424

25-
void fd_id_show_tree(void)
26-
{
27-
kid_show_tree(&fd_tree);
28-
}
29-
3025
#define FDID_BITS 5
3126
#define FDID_SIZE (1 << FDID_BITS)
3227
#define FDID_MASK (FDID_SIZE - 1)

include/file-ids.h

-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,5 @@ struct stat;
1616
struct fd_parms;
1717
extern int fd_id_generate(pid_t pid, FdinfoEntry *fe, struct fd_parms *p);
1818
extern int fd_id_generate_special(struct fd_parms *p, u32 *id);
19-
extern void fd_id_show_tree(void);
2019

2120
#endif /* __CR_FILE_IDS_H__ */

include/kcmp-ids.h

-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,5 @@ struct kid_elem {
2525

2626
extern u32 kid_generate_gen(struct kid_tree *tree,
2727
struct kid_elem *elem, int *new_id);
28-
extern void kid_show_tree(struct kid_tree *tree);
2928

3029
#endif /* __CR_KCMP_IDS_H__ */

kcmp-ids.c

-53
Original file line numberDiff line numberDiff line change
@@ -56,59 +56,6 @@ struct kid_entry {
5656
struct kid_elem elem;
5757
} __aligned(sizeof(long));
5858

59-
static void show_subnode(struct rb_node *node, int self)
60-
{
61-
struct kid_entry *this = rb_entry(node, struct kid_entry, subtree_node);
62-
63-
pr_info("\t\t| %#x.%#x %s\n", this->elem.genid, this->subid,
64-
self ? "(self)" : "");
65-
if (node->rb_left) {
66-
pr_info("\t\t| left:\n");
67-
show_subnode(node->rb_left, 0);
68-
pr_info("\t\t| --l\n");
69-
}
70-
if (node->rb_right) {
71-
pr_info("\t\t| right:\n");
72-
show_subnode(node->rb_right, 0);
73-
pr_info("\t\t| --r\n");
74-
}
75-
}
76-
77-
static void show_subtree(struct rb_root *root)
78-
{
79-
pr_info("\t\t| SubTree\n");
80-
show_subnode(root->rb_node, 1);
81-
}
82-
83-
static void show_node(struct rb_node *node)
84-
{
85-
struct kid_entry *this = rb_entry(node, struct kid_entry, node);
86-
87-
pr_info("\t%#x.%#x\n", this->elem.genid, this->subid);
88-
if (node->rb_left) {
89-
pr_info("\tleft:\n");
90-
show_node(node->rb_left);
91-
pr_info("\t--l\n");
92-
}
93-
if (node->rb_right) {
94-
pr_info("\tright:\n");
95-
show_node(node->rb_right);
96-
pr_info("\t--r\n");
97-
}
98-
99-
show_subtree(&this->subtree_root);
100-
pr_info("\t--s\n");
101-
}
102-
103-
void kid_show_tree(struct kid_tree *tree)
104-
{
105-
struct rb_root *root = &tree->root;
106-
107-
pr_info("\tTree of %d objects\n", tree->kcmp_type);
108-
if (root->rb_node)
109-
show_node(root->rb_node);
110-
}
111-
11259
static struct kid_entry *alloc_kid_entry(struct kid_tree *tree, struct kid_elem *elem)
11360
{
11461
struct kid_entry *e;

0 commit comments

Comments
 (0)