fix(case manager): change open api dto for case review (#967)

Author: ChibiBlasphem

packages/app-builder/src/models/cases.ts

@@ -574,16 +574,14 @@ export function adaptPivotObject(dto: PivotObjectDto): PivotObject {
 
 export type CaseReview = {
   output: string;
-  sanityCheck: string;
-  thought: string;
-  ok: boolean;
-};
+  thought?: string;
+} & ({ ok: true; sanityCheck?: undefined } | { ok: false; sanityCheck: string });
 
 export function adaptCaseReview(dto: CaseReviewDto): CaseReview {
-  return {
-    output: dto.output,
-    sanityCheck: dto.sanity_check,
-    thought: dto.thought,
-    ok: dto.ok,
-  };
+  const baseCaseReview = { output: dto.output, thought: dto.thought } as const;
+
+  if (!dto.ok) {
+    return { ...baseCaseReview, ok: false, sanityCheck: dto.sanity_check };
+  }
+  return { ...baseCaseReview, ok: true };
 }

packages/marble-api/openapis/marblecore-api/_schemas.yml

@@ -131,6 +131,10 @@ PivotObjectDto:
   $ref: cases.yml#/components/schemas/PivotObjectDto
 CaseReviewDto:
   $ref: cases.yml#/components/schemas/CaseReviewDto
+CaseReviewOkDto:
+  $ref: cases.yml#/components/schemas/CaseReviewOkDto
+CaseReviewNotOkDto:
+  $ref: cases.yml#/components/schemas/CaseReviewNotOkDto
 
 # SUSPICIOUS ACTIVITY REPORTS
 

packages/marble-api/openapis/marblecore-api/cases.yml

@@ -1359,18 +1359,35 @@ components:
         - pivot_object_data
         - number_of_decisions
     CaseReviewDto:
+      allOf:
+        - type: object
+          required:
+            - output
+          properties:
+            output:
+              type: string
+            thought:
+              type: string
+        - anyOf:
+          - $ref: '#/components/schemas/CaseReviewOkDto'
+          - $ref: '#/components/schemas/CaseReviewNotOkDto'
+
+    CaseReviewOkDto:
+      type: object
+      required:
+        - ok
+      properties:
+        ok:
+          type: boolean
+          enum: [true]
+    CaseReviewNotOkDto:
       type: object
       required:
         - ok
-        - output
         - sanity_check
-        - thought
       properties:
         ok:
           type: boolean
-        output:
-          type: string
+          enum: [false]
         sanity_check:
           type: string
-        thought:
-          type: string

packages/marble-api/src/generated/marblecore-api.ts

@@ -425,12 +425,17 @@ export type PivotObjectDto = {
 export type NextCaseIdDto = {
     id: string;
 };
-export type CaseReviewDto = {
-    ok: boolean;
-    output: string;
+export type CaseReviewOkDto = {
+    ok: true;
+};
+export type CaseReviewNotOkDto = {
+    ok: false;
     sanity_check: string;
-    thought: string;
 };
+export type CaseReviewDto = {
+    output: string;
+    thought?: string;
+} & (CaseReviewOkDto | CaseReviewNotOkDto);
 export type SuspiciousActivityReportDto = {
     id: string;
     status: "pending" | "completed";