Skip to content

Commit b76d6b4

Browse files
committed
Better argument naming and comments
1 parent 3183b55 commit b76d6b4

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/adapters/adapter.moment.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ helpers.merge(adapter, moment ? {
5656
return moment.duration(moment(max).diff(moment(min))).as(unit);
5757
},
5858

59-
startOf: function(time, unit, opt) {
59+
startOf: function(time, unit, weekday) {
6060
time = moment(time);
6161
if (unit === 'isoWeek') {
62-
return +time.isoWeekday(opt);
62+
return +time.isoWeekday(weekday);
6363
}
6464
return +time.startOf(unit);
6565
},

src/chart.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Chart.helpers.each(scales, function(scale, type) {
3131
Chart.scaleService.registerScaleType(type, scale, scale._defaults);
3232
});
3333

34-
// Built-in adapters (loaded for side effects)
34+
// Load to register built-in adapters (as side effects)
3535
require('./adapters');
3636

3737
// Loading built-in plugins

src/core/core.adapters.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,8 @@ module.exports._date = {
8686
* Returns start of `unit` for the given `timestamp`.
8787
* @param {number} timestamp - the input timestamp
8888
* @param {Unit} unit - the unit as string
89+
* @param {number} [weekday] - the ISO day of the week with 1 being Monday
90+
* and 7 being Sunday (only needed if param *unit* is `isoWeek`).
8991
* @function
9092
*/
9193
startOf: abstract,

0 commit comments

Comments
 (0)