Skip to content

Commit 4fc7704

Browse files
committed
nonNegativeOrDefault
1 parent 46aa706 commit 4fc7704

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/scales/scale.logarithmic.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ var defaultConfig = {
6262
}
6363
};
6464

65-
// TODO(v3): change this to isPositive
66-
function isNonNegative(value) {
67-
return helpers.isFinite(value) && value >= 0;
65+
// TODO(v3): change this to isPositiveOrDefault
66+
function nonNegativeOrDefault(value, defaultValue) {
67+
return helpers.isFinite(value) && value >= 0 ? value : defaultValue;
6868
}
6969

7070
module.exports = Scale.extend({
@@ -179,8 +179,8 @@ module.exports = Scale.extend({
179179
var DEFAULT_MIN = 1;
180180
var DEFAULT_MAX = 10;
181181

182-
me.min = isNonNegative(tickOpts.min) ? tickOpts.min : me.min;
183-
me.max = isNonNegative(tickOpts.max) ? tickOpts.max : me.max;
182+
me.min = nonNegativeOrDefault(tickOpts.min, me.min);
183+
me.max = nonNegativeOrDefault(tickOpts.max, me.max);
184184

185185
if (me.min === me.max) {
186186
if (me.min !== 0 && me.min !== null) {
@@ -216,8 +216,8 @@ module.exports = Scale.extend({
216216
var reverse = !me.isHorizontal();
217217

218218
var generationOptions = {
219-
min: isNonNegative(tickOpts.min) ? tickOpts.min : undefined,
220-
max: isNonNegative(tickOpts.max) ? tickOpts.max : undefined
219+
min: nonNegativeOrDefault(tickOpts.min),
220+
max: nonNegativeOrDefault(tickOpts.max)
221221
};
222222
var ticks = me.ticks = generateTicks(generationOptions, me);
223223

0 commit comments

Comments
 (0)