Skip to content

Commit 9a07c32

Browse files
committed
fix(table): remove unecessary code
1 parent b00d086 commit 9a07c32

File tree

1 file changed

+1
-19
lines changed

1 file changed

+1
-19
lines changed

table/table.go

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ func (m Model) HelpView() string {
264264
func (m *Model) UpdateViewport() {
265265
renderedRows := make([]string, 0, len(m.rows))
266266

267-
// Render only rows from: m.cursor-m.viewport.Height to: m.cursor+m.viewport.Height
267+
// Render only rows from: m.cursor-(m.viewport.Height-1) to: m.cursor+m.viewport.Height
268268
// Constant runtime, independent of number of rows in a table.
269269
// Limits the number of renderedRows to a maximum of 2*m.viewport.Height
270270
if m.cursor >= 0 {
@@ -351,14 +351,6 @@ func (m *Model) SetCursor(n int) {
351351
// It can not go above the first row.
352352
func (m *Model) MoveUp(n int) {
353353
m.cursor = clamp(m.cursor-n, 0, len(m.rows)-1)
354-
switch {
355-
case m.start == 0:
356-
m.viewport.SetYOffset(clamp(m.viewport.YOffset, 0, m.cursor))
357-
case m.start < m.viewport.Height:
358-
m.viewport.YOffset = (clamp(clamp(m.viewport.YOffset+n, 0, m.cursor), 0, m.viewport.Height))
359-
case m.viewport.YOffset >= 1:
360-
m.viewport.YOffset = clamp(m.viewport.YOffset+n, 1, m.viewport.Height)
361-
}
362354
m.UpdateViewport()
363355
}
364356

@@ -367,16 +359,6 @@ func (m *Model) MoveUp(n int) {
367359
func (m *Model) MoveDown(n int) {
368360
m.cursor = clamp(m.cursor+n, 0, len(m.rows)-1)
369361
m.UpdateViewport()
370-
371-
switch {
372-
case m.end == len(m.rows) && m.viewport.YOffset > 0:
373-
m.viewport.SetYOffset(clamp(m.viewport.YOffset-n, 1, m.viewport.Height))
374-
case m.cursor > (m.end-m.start)/2 && m.viewport.YOffset > 0:
375-
m.viewport.SetYOffset(clamp(m.viewport.YOffset-n, 1, m.cursor))
376-
case m.viewport.YOffset > 1:
377-
case m.cursor > m.viewport.YOffset+m.viewport.Height-1:
378-
m.viewport.SetYOffset(clamp(m.viewport.YOffset+1, 0, 1))
379-
}
380362
}
381363

382364
// GotoTop moves the selection to the first row.

0 commit comments

Comments
 (0)