Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose builds pip 6 times #3045

Open
cdolfi opened this issue Mar 10, 2025 · 4 comments · May be fixed by #3078
Open

Docker compose builds pip 6 times #3045

cdolfi opened this issue Mar 10, 2025 · 4 comments · May be fixed by #3078

Comments

@cdolfi
Copy link
Contributor

cdolfi commented Mar 10, 2025

In the docker compose pip is built 6 times, is this necessary?
https://github.com/chaoss/augur/blob/main/docker/backend/Dockerfile#L105-119

@MoralCode
Copy link
Contributor

i doubt it is necessary - if it was i suspect there would be a comment explaining why its necessary

you could at least get it down by ~ half by removing either the RUN call that does them all in one step, or the three that splits it out separately

I personally would probably also try and remove the venv things and just install directly, because at that point youre running an isolated virtual environment (designed to help keep things separated on a host that has multiple programs with possibly conflicting dependencies) into a container (which is seemingly used as a single-purpose environment just for augur)

while not directly related, i figure id also add #3006 as a reference since i probably would have mentioned this if i had noticed it while filing that issue/PR

@cdolfi
Copy link
Contributor Author

cdolfi commented Mar 11, 2025

That makes senes. In the docker clean up process cutting this down a bit might be a good idea

@sgoggins
Copy link
Member

I am of course a little skittish about changing anything related to Docker. @MoralCode : Do you think this is ready to be merged, or should we ask @GregSutcliffe ?

@MoralCode
Copy link
Contributor

MoralCode commented Mar 18, 2025

Do you think this is ready to be merged

this is an issue. Is there a related pull request?

I think it is relatively safe to remove the obvious duplication in the dockerfile, but i can test this alongside my fixes for #3053 too if that helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants