-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker compose builds pip 6 times #3045
Comments
i doubt it is necessary - if it was i suspect there would be a comment explaining why its necessary you could at least get it down by ~ half by removing either the I personally would probably also try and remove the while not directly related, i figure id also add #3006 as a reference since i probably would have mentioned this if i had noticed it while filing that issue/PR |
That makes senes. In the docker clean up process cutting this down a bit might be a good idea |
I am of course a little skittish about changing anything related to Docker. @MoralCode : Do you think this is ready to be merged, or should we ask @GregSutcliffe ? |
this is an issue. Is there a related pull request? I think it is relatively safe to remove the obvious duplication in the dockerfile, but i can test this alongside my fixes for #3053 too if that helps |
In the docker compose pip is built 6 times, is this necessary?
https://github.com/chaoss/augur/blob/main/docker/backend/Dockerfile#L105-119
The text was updated successfully, but these errors were encountered: