Skip to content

ci: enhance Claude GitHub Actions and documentation #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 9, 2025

Conversation

codemonkey800
Copy link
Contributor

Summary

This PR enhances the Claude GitHub Actions workflows and consolidates development documentation for the CryoET Data Portal project. The changes improve automated code review capabilities and provide comprehensive development guidance.

Changes

  • CI/CD Enhancement: Updated Claude GitHub Actions workflows with comprehensive code review prompts tailored for CryoET Data Portal
  • Documentation Consolidation: Migrated Claude commands to repository root and created comprehensive CLAUDE.md
  • Frontend Documentation: Enhanced frontend-specific documentation with detailed command reference and development standards
  • Workflow Configuration: Added context-aware review criteria for frontend (React/TypeScript) and Python code
  • Developer Experience: Improved development workflow with better tooling and documentation structure

Key Improvements

GitHub Actions

  • Added comprehensive code review prompts specific to scientific data platform requirements
  • Enabled sticky comments for consistent PR feedback
  • Configured allowed tools for development commands (pnpm, npm, git, python)
  • Added sequential thinking MCP integration for better code analysis

Documentation Structure

  • Consolidated all Claude commands and guidance in repository root
  • Created comprehensive CLAUDE.md with project overview, commands, and architecture
  • Enhanced frontend/CLAUDE.md with detailed command reference
  • Documented testing setup, code quality standards, and development workflows

Testing

The changes primarily affect documentation and CI configuration. To test:

Frontend Development:

cd frontend && pnpm test
cd frontend && pnpm e2e
cd frontend && pnpm lint
cd frontend && pnpm type-check

Documentation:

cd docs && make html

Files Changed

  • .github/workflows/claude-code-review.yml: Enhanced with CryoET-specific review criteria
  • .github/workflows/claude.yml: Added comprehensive custom instructions and tooling
  • CLAUDE.md: New comprehensive project documentation
  • .claude/commands/: Migrated command files to repository root
  • frontend/CLAUDE.md: Enhanced with detailed development guidance

🤖 Generated with Claude Code

codemonkey800 and others added 5 commits July 7, 2025 16:30
- Add comprehensive code review prompts for CryoET Data Portal
- Enable sticky comments and sequential thinking MCP
- Add context-aware review criteria for frontend and Python code
- Configure allowed tools for development commands
- Add detailed custom instructions for repository context

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Move .claude/commands/ from frontend/ to repository root
- Add comprehensive CLAUDE.md with project overview and commands
- Remove duplicate command files from frontend directory
- Consolidate development guidance in single location

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Add comprehensive command reference with individual linters
- Document E2E testing setup and browser installation
- Add CSS build tooling and typed CSS modules setup
- Include development workflow and testing configuration
- Document code quality standards and TypeScript setup

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@codemonkey800
Copy link
Contributor Author

@jfoo1984 added you as an optional reviewer since you've been using claude code a bit longer and have experience setting these things up 🤣 🙏

@codemonkey800 codemonkey800 marked this pull request as ready for review July 8, 2025 00:37
@jfoo1984
Copy link

jfoo1984 commented Jul 8, 2025

@jfoo1984 added you as an optional reviewer since you've been using claude code a bit longer and have experience setting these things up 🤣 🙏

thanks @codemonkey800! I haven't actually set up anything for claude beyond a claude.md, but this looks good, and seems like something that we should set up in other repos!

- Move issue reference to the very top of PR body as #ISSUE_NUMBER
- Remove 'Closes #' keyword to avoid auto-closing issues
- Add clear example of PR body format with issue reference
- Clarify that issue number should be on its own line
@codemonkey800
Copy link
Contributor Author

@jfoo1984 added you as an optional reviewer since you've been using claude code a bit longer and have experience setting these things up 🤣 🙏

thanks @codemonkey800! I haven't actually set up anything for claude beyond a claude.md, but this looks good, and seems like something that we should set up in other repos!

no worries, thank you for still reviewing! I agree, we should definitely add this to other repos too

@codemonkey800 codemonkey800 merged commit e0093eb into main Jul 9, 2025
12 checks passed
@codemonkey800 codemonkey800 deleted the add-claude-github-actions-1751931008287 branch July 9, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants