feat: add deposition information to dataset metadata display (#1873)

codemonkey800 · claude · web-flow · commit 79293cfbfb08 · 2025-07-07T15:34:58.000-07:00
* feat: add deposition fields to GraphQL queries - Add title field to dataset deposition query - Add id and title fields to run deposition query - Enables displaying deposition information in metadata tables 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * feat: add deposition-related translation keys - Add additionalContributions translation - Add originalDepositionId translation - Add originalDepositionName translation - Support new deposition metadata display labels 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * feat: add deposition info to dataset metadata table - Add original deposition name with link to deposition page - Add original deposition ID with proper formatting - Add additional contributions list with deposition links - Enhance metadata table with deposition-related information 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * feat: add deposition queries for additional contributions Add GraphQL queries to fetch depositions that contribute to datasets/runs through annotations, tomograms, or direct dataset associations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * feat: process additional contributing depositions in hooks Extract and filter additional contributing depositions from GraphQL data, excluding original deposition and returning sorted unique IDs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * feat: display dynamic additional contributions in metadata Replace hardcoded deposition IDs with dynamic data from hooks in DatasetMetadataTable and pass through DatasetMetadataDrawer and RunMetadataDrawer components. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: handle when id is undefined * refactor: extract additional contributing depositions logic to utility function Extract duplicate logic for getting additional contributing depositions into a reusable utility function. This eliminates code duplication between useDatasetById and useRunById hooks while maintaining the same functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
diff --git a/frontend/packages/data-portal/app/components/Dataset/DatasetMetadataDrawer.tsx b/frontend/packages/data-portal/app/components/Dataset/DatasetMetadataDrawer.tsx
@@ -24,11 +24,14 @@ export function DatasetMetadataDrawer() {
 }
 
 function MetadataTab() {
-  const { dataset } = useDatasetById()
+  const { dataset, additionalContributingDepositions } = useDatasetById()
 
   return (
     <>
-      <DatasetMetadataTable dataset={dataset} />
+      <DatasetMetadataTable
+        dataset={dataset}
+        additionalContributingDepositions={additionalContributingDepositions}
+      />
       <SampleAndExperimentConditionsTable dataset={dataset} />
       <DatasetTiltSeriesTable />
     </>
diff --git a/frontend/packages/data-portal/app/components/Dataset/DatasetMetadataTable.tsx b/frontend/packages/data-portal/app/components/Dataset/DatasetMetadataTable.tsx
@@ -39,10 +39,12 @@ export function DatasetMetadataTable({
   dataset,
   showAllFields,
   initialOpen,
+  additionalContributingDepositions = [],
 }: {
   dataset: Dataset
   showAllFields?: boolean
   initialOpen?: boolean
+  additionalContributingDepositions?: number[]
 }) {
   const { t } = useI18n()
 
@@ -115,6 +117,60 @@ export function DatasetMetadataTable({
       values: [dataset.depositionDate?.split('T')[0] ?? ''],
     },
 
+    {
+      label: t('originalDepositionName'),
+      values: [dataset.deposition?.title ?? ''],
+      renderValue: (value: string) => {
+        const id = dataset.deposition?.id
+
+        if (!id) {
+          return <span>--</span>
+        }
+
+        return (
+          <Link
+            className="text-light-sds-color-primitive-blue-500"
+            to={`/depositions/${id}`}
+          >
+            {value}
+          </Link>
+        )
+      },
+    },
+
+    {
+      label: t('originalDepositionId'),
+      values: [dataset.deposition?.id ?? '--'],
+      renderValue: (value: string) => {
+        return (
+          <span>
+            {IdPrefix.Deposition}-{value}
+          </span>
+        )
+      },
+    },
+
+    {
+      label: t('additionalContributions'),
+      values: additionalContributingDepositions,
+      renderValues(values) {
+        return (
+          <ul>
+            {values.map((value) => (
+              <li key={value}>
+                <Link
+                  className="text-light-sds-color-primitive-blue-500"
+                  to={`/depositions/${value}`}
+                >
+                  {IdPrefix.Deposition}-{value}
+                </Link>
+              </li>
+            ))}
+          </ul>
+        )
+      },
+    },
+
     {
       label: t('releaseDate'),
       values: [dataset.releaseDate?.split('T')[0] ?? ''],
diff --git a/frontend/packages/data-portal/app/components/Run/RunMetadataDrawer.tsx b/frontend/packages/data-portal/app/components/Run/RunMetadataDrawer.tsx
@@ -25,7 +25,7 @@ export function RunMetadataDrawer() {
 }
 
 function MetadataTab() {
-  const { run } = useRunById()
+  const { run, additionalContributingDepositions } = useRunById()
 
   return (
     <>
@@ -35,6 +35,9 @@ function MetadataTab() {
             showAllFields
             dataset={run.dataset}
             initialOpen={false}
+            additionalContributingDepositions={
+              additionalContributingDepositions
+            }
           />
           <SampleAndExperimentConditionsTable
             dataset={run.dataset}
diff --git a/frontend/packages/data-portal/app/graphql/getDatasetByIdV2.server.ts b/frontend/packages/data-portal/app/graphql/getDatasetByIdV2.server.ts
@@ -42,6 +42,7 @@ const GET_DATASET_BY_ID_QUERY_V2 = gql(`
       deposition{
         id
         description
+        title
         annotationsAggregate(where: {annotationShapes: {annotationFilesAggregate: {count: {filter: {isVisualizationDefault: {_eq: true}}}}}}) {
           aggregate {
             count
@@ -221,6 +222,34 @@ const GET_DATASET_BY_ID_QUERY_V2 = gql(`
       id
       title
     }
+
+    depositionsWithAnnotations: depositions(where: {
+      annotations: {
+        run: {
+          datasetId: { _eq: $id }
+        }
+      }
+    }) {
+      id
+    }
+
+    depositionsWithTomograms: depositions(where: {
+      tomograms: {
+        run: {
+          datasetId: { _eq: $id }
+        }
+      }
+    }) {
+      id
+    }
+
+    depositionsWithDatasets: depositions(where: {
+      datasets: {
+        id: { _eq: $id }
+      }
+    }) {
+      id
+    }
   }
 `)
 
diff --git a/frontend/packages/data-portal/app/graphql/getRunByIdV2.server.ts b/frontend/packages/data-portal/app/graphql/getRunByIdV2.server.ts
@@ -68,6 +68,9 @@ const GET_RUN_BY_ID_QUERY_V2 = gql(`
         cellStrainId
         cellTypeId
         deposition {
+          id
+          title
+
           annotationsAggregate(
             where: {annotationShapesAggregate: {count: {filter: {annotationFiles: {isVisualizationDefault: {_eq: true}}}}}}
           ) {
@@ -467,6 +470,32 @@ const GET_RUN_BY_ID_QUERY_V2 = gql(`
       id
       title
     }
+
+    depositionsWithAnnotations: depositions(where: {
+      annotations: {
+        runId: { _eq: $id }
+      }
+    }) {
+      id
+    }
+
+    depositionsWithTomograms: depositions(where: {
+      tomograms: {
+        runId: { _eq: $id }
+      }
+    }) {
+      id
+    }
+
+    depositionsWithDatasets: depositions(where: {
+      datasets: {
+        runs: {
+          id: { _eq: $id }
+        }
+      }
+    }) {
+      id
+    }
   }
 `)
 
diff --git a/frontend/packages/data-portal/app/hooks/useDatasetById.ts b/frontend/packages/data-portal/app/hooks/useDatasetById.ts
@@ -1,6 +1,7 @@
 import { useTypedLoaderData } from 'remix-typedjson'
 
 import { GetDatasetByIdV2Query } from 'app/__generated_v2__/graphql'
+import { getAdditionalContributingDepositions } from 'app/utils/deposition'
 import { isDefined } from 'app/utils/nullish'
 
 export function useDatasetById() {
@@ -31,6 +32,15 @@ export function useDatasetById() {
       ?.map((aggregate) => aggregate.groupBy?.tiltSeriesQuality)
       .filter(isDefined) ?? []
 
+  // Get additional contributing depositions (excluding the original deposition)
+  const additionalContributingDepositions =
+    getAdditionalContributingDepositions(
+      v2.depositionsWithAnnotations,
+      v2.depositionsWithTomograms,
+      v2.depositionsWithDatasets,
+      dataset?.deposition?.id,
+    )
+
   return {
     runs,
     unFilteredRuns,
@@ -39,5 +49,6 @@ export function useDatasetById() {
     objectNames,
     objectShapeTypes,
     tiltseriesQualityScores,
+    additionalContributingDepositions,
   }
 }
diff --git a/frontend/packages/data-portal/app/hooks/useRunById.ts b/frontend/packages/data-portal/app/hooks/useRunById.ts
@@ -1,6 +1,7 @@
 import { useTypedLoaderData } from 'remix-typedjson'
 
 import { GetRunByIdV2Query } from 'app/__generated_v2__/graphql'
+import { getAdditionalContributingDepositions } from 'app/utils/deposition'
 import { isDefined } from 'app/utils/nullish'
 
 export function useRunById() {
@@ -81,6 +82,15 @@ export function useRunById() {
 
   const deposition = v2.depositions[0]
 
+  // Get additional contributing depositions (excluding the original deposition)
+  const additionalContributingDepositions =
+    getAdditionalContributingDepositions(
+      v2.depositionsWithAnnotations,
+      v2.depositionsWithTomograms,
+      v2.depositionsWithDatasets,
+      run?.dataset?.deposition?.id,
+    )
+
   return {
     run,
     tomograms,
@@ -95,5 +105,6 @@ export function useRunById() {
     ctfCount,
     deposition,
     annotationShapes,
+    additionalContributingDepositions,
   }
 }
diff --git a/frontend/packages/data-portal/app/utils/deposition.ts b/frontend/packages/data-portal/app/utils/deposition.ts
@@ -1,5 +1,26 @@
 import type { DataContentsFragment } from 'app/__generated_v2__/graphql'
 
+interface DepositionWithId {
+  id: number
+}
+
+export function getAdditionalContributingDepositions(
+  depositionsWithAnnotations: DepositionWithId[] | null | undefined,
+  depositionsWithTomograms: DepositionWithId[] | null | undefined,
+  depositionsWithDatasets: DepositionWithId[] | null | undefined,
+  originalDepositionId: number | null | undefined,
+): number[] {
+  return Array.from(
+    new Set([
+      ...(depositionsWithAnnotations?.map((dep) => dep.id) ?? []),
+      ...(depositionsWithTomograms?.map((dep) => dep.id) ?? []),
+      ...(depositionsWithDatasets?.map((dep) => dep.id) ?? []),
+    ]),
+  )
+    .filter((id) => id !== originalDepositionId)
+    .sort((a, b) => a - b)
+}
+
 export function getDataContents(runs: DataContentsFragment[]) {
   let annotations = 0
   let tomograms = 0
diff --git a/frontend/packages/data-portal/public/locales/en/translation.json b/frontend/packages/data-portal/public/locales/en/translation.json
@@ -12,6 +12,7 @@
   "acquisitionMethods": "Acquisition Methods",
   "acrossDatasets_one": "Across {{count}} Dataset",
   "acrossDatasets_other": "Across {{count}} Datasets",
+  "additionalContributions": "Additional Contributions",
   "additionalMicroscopeOpticalSetup": "Additional microscope optical setup",
   "affiliationName": "Affiliation Name",
   "affiliationNames": "Affiliation Names",
@@ -360,6 +361,8 @@
   "organizers": "Organizers",
   "orientedPoint": "Oriented Point",
   "orientedPoints": "Oriented Points",
+  "originalDepositionId": "Original Deposition ID",
+  "originalDepositionName": "Original Deposition Name",
   "other": "Other",
   "otherAnnotations_one": "{{count}} Other Annotation",
   "otherAnnotations_other": "{{count}} Other Annotations",
