Fix Debug Frames & Merge Path (#917)

* tree: Fix transformation and support named nodes

- Fixes transformations on the tree
- Support named elements in tree nodes

* tree: Fix transformation + node anchors

* debug: Fix debug paths

* merge-path: Fix Path Closing

* merge-path: Update tests

* changelog: Update changelog

Author: johannes-wolf

CHANGES.md

@@ -5,8 +5,10 @@
 - **BREAKING** The `tree` callback for drawing nodes does not pass the parent nodes name anymore (new signature is `(node) => elements`)
 - **BREAKING** The `parent-position` argument of `tree` got removed
 - Tree nodes now support anchors: custom anchors from the `draw-node` callback
-  are accessible.
+  are accessible (#904)
 - `styles.resolve` now supports nested roots by passing an array (#914)
+- Fixed debug frames (#917)
+- Fixed a regression with `merge-path`'s `close:` argument (#910)
 
 # 0.4.0
 - Fixed a bug where passing a length as radius to a polygon resulted in an error

src/draw/shapes.typ

@@ -1764,7 +1764,6 @@
             segments.push(("l", next-origin))
             segments += next-segments
 
-            // TODO: Close is not working as expected here
             subpaths.last() = (origin, closed or close, segments)
             subpaths += drawables.slice(1).filter(d => {
               d.type == "path"
@@ -1777,6 +1776,13 @@
         }
       }
 
+      // Close paths
+      if close {
+        subpaths = subpaths.map(((origin, closed, elems)) => {
+          (origin, close or closed, elems)
+        })
+      }
+
       let style = styles.resolve(ctx.style, merge: style)
       let drawables = drawable.path(fill: style.fill, fill-rule: style.fill-rule, stroke: style.stroke, subpaths)
 

src/process.typ

@@ -51,14 +51,14 @@
   }
 
   if ctx.debug and bounds != none {
-    element.drawables.push(drawable.path(
-      ((bounds.low, true, (
-        ("l", (bounds.high.at(0), bounds.low.at(1), 0)),
-        ("l", bounds.high),
-        ("l", (bounds.low.at(0), bounds.high.at(1), 0)))),),
-      stroke: red,
-      close: true
-    ))
+    element.drawables.push(drawable.line-strip(
+      (bounds.low,
+        (bounds.high.at(0), bounds.low.at(1), 0.0),
+        bounds.high,
+        (bounds.low.at(0), bounds.high.at(1), 0.0)
+      ),
+      close: true,
+      stroke: red))
   }
 
   return (

tests/merge/ref/1.png

@@ -47,3 +47,11 @@
     circle((name: "p", anchor: 1% * i), radius: .1, fill: white)
   }
 })
+
+#test-case({
+  import draw: *
+
+  merge-path(close: true, fill: red, {
+    line((0,0), (1,0), (1,1))
+  })
+})