refactor: Use callback-based OpenKey method for registry key read/write operations

Author: cetteup

pkg/registry_repository/registry_repository.go

@@ -11,16 +11,29 @@ func New() *RegistryRepository {
 	return &RegistryRepository{}
 }
 
-func (r *RegistryRepository) GetStringValue(k registry.Key, path string, valueName string) (string, error) {
-	key, err := registry.OpenKey(k, path, registry.QUERY_VALUE)
+func (r *RegistryRepository) OpenKey(k registry.Key, path string, access uint32, cb func(key registry.Key) error) error {
+	key, err := registry.OpenKey(k, path, access)
 	if err != nil {
-		return "", err
+		return err
 	}
 	defer func(key registry.Key) {
 		_ = key.Close()
 	}(key)
 
-	value, _, err := key.GetStringValue(valueName)
+	return cb(key)
+}
+
+func (r *RegistryRepository) GetStringValue(k registry.Key, path string, valueName string) (string, error) {
+	var value string
+	err := r.OpenKey(k, path, registry.QUERY_VALUE, func(key registry.Key) error {
+		var err error
+		value, _, err = key.GetStringValue(valueName)
+		if err != nil {
+			return err
+		}
+
+		return nil
+	})
 	if err != nil {
 		return "", err
 	}
@@ -29,27 +42,15 @@ func (r *RegistryRepository) GetStringValue(k registry.Key, path string, valueNa
 }
 
 func (r *RegistryRepository) SetStringValue(k registry.Key, path string, valueName string, value string) error {
-	key, err := registry.OpenKey(k, path, registry.QUERY_VALUE|registry.SET_VALUE)
-	if err != nil {
-		return err
-	}
-	defer func(key registry.Key) {
-		_ = key.Close()
-	}(key)
-
-	return key.SetStringValue(valueName, value)
+	return r.OpenKey(k, path, registry.QUERY_VALUE|registry.SET_VALUE, func(key registry.Key) error {
+		return key.SetStringValue(valueName, value)
+	})
 }
 
 func (r *RegistryRepository) DeleteValue(k registry.Key, path string, valueName string) error {
-	key, err := registry.OpenKey(k, path, registry.QUERY_VALUE|registry.SET_VALUE)
-	if err != nil {
-		return err
-	}
-	defer func(key registry.Key) {
-		_ = key.Close()
-	}(key)
-
-	return key.DeleteValue(valueName)
+	return r.OpenKey(k, path, registry.QUERY_VALUE|registry.SET_VALUE, func(key registry.Key) error {
+		return key.DeleteValue(valueName)
+	})
 }
 
 func (r *RegistryRepository) CreateKey(k registry.Key, path string) error {