Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is google-api-core dependency actually needed? #1250

Open
micwoj92 opened this issue Mar 26, 2025 · 0 comments
Open

Is google-api-core dependency actually needed? #1250

micwoj92 opened this issue Mar 26, 2025 · 0 comments
Labels

Comments

@micwoj92
Copy link

Describe your environment.
Opencensus 0.11.4

Steps to reproduce.
Check code for google-api-core imports.

What is the expected behavior?
Some imports

What is the actual behavior?
No imports

Additional context.
I've seen pull request #1075 which tries to remove this dependency, but @aabmass said:

Ah, so this won't work because of one actual use of protobuf library here:

from google.protobuf.internal.encoder import _VarintBytes

However google.protobuf.internal.encoder is provided by protobuf package and not google-api-core. If there is something that I understand incorreclty, please let me know, thanks.

@micwoj92 micwoj92 added the bug label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant