Exporter/Zipkin: Enforce strictNullChecks and noUnusedLocals (#381)

* Exporter/Zipkin: Enforce strictNullChecks and noUnusedLocals

* minor fix

Author: mayurkale22

CHANGELOG.md

@@ -14,6 +14,7 @@ All notable changes to this project will be documented in this file.
 - Add support for recording gRPC stats.
 - Add support for recording HTTP stats.
 - Enforce `--strictNullChecks` and `--noUnusedLocals` Compiler Options on [opencensus-instrumentation-http], [opencensus-instrumentation-grpc] and [opencensus-propagation-tracecontext] packages.
+- Enforce `--strictNullChecks` and `--noUnusedLocals` Compiler Options on  [opencensus-exporter-zipkin] packages.
 
 ## 0.0.9 - 2019-02-12
 - Add Metrics API.

packages/opencensus-exporter-zipkin/README.md

@@ -1,7 +1,12 @@
-# OpenCensus Zipkin Exporter for Node.js
+# OpenCensus Zipkin Trace Exporter
 [![Gitter chat][gitter-image]][gitter-url]
 
-OpenCensus Zipkin Exporter allows the user to send collected traces with [OpenCensus Node.js](https://github.com/census-instrumentation/opencensus-node) to Zipkin.
+OpenCensus Zipkin Trace Exporter allows the user to send collected traces with [OpenCensus Node.js](https://github.com/census-instrumentation/opencensus-node) to Zipkin.
+
+[Zipkin](http://zipkin.io/) is a distributed
+tracing system. It helps gather timing data needed to troubleshoot
+latency problems in microservice architectures. It manages both the
+collection and lookup of this data.
 
 This project is still at an early stage of development. It's subject to change.
 
@@ -15,7 +20,7 @@ npm install @opencensus/exporter-zipkin
 
 ## Usage
 
-To use Zipkin as your exporter, first, download from any of the three available options on [Quickstart](https://zipkin.io/pages/quickstart.html): through Docker, on Java or manually compiling the source code. Tests were executed running Zipkin with Java, through the following commands on terminal:
+To use [Zipkin](http://zipkin.io/) as your exporter, first, download from any of the three available options on [Quickstart](https://zipkin.io/pages/quickstart.html): through Docker, on Java or manually compiling the source code. Tests were executed running Zipkin with Java, through the following commands on terminal:
 
 ```bash
 wget -O zipkin.jar 'https://search.maven.org/remote_content?g=io.zipkin.java&a=zipkin-server&v=LATEST&c=exec'

packages/opencensus-exporter-zipkin/src/zipkin.ts

@@ -35,7 +35,7 @@ export interface ZipkinExporterOptions extends ExporterConfig {
   serviceName: string;
 }
 
-interface TranslatedSpan {
+export interface TranslatedSpan {
   traceId: string;
   name: string;
   id: string;
@@ -50,7 +50,7 @@ interface TranslatedSpan {
   tags: {[key: string]: string};
 }
 
-interface Annotation {
+export interface Annotation {
   timestamp?: number;  // in microseconds
   value?: string;
 }

packages/opencensus-exporter-zipkin/test/test-zipkin.ts

@@ -29,8 +29,7 @@ const postPath = '/api/v2/spans';
  * true to use a real zipkin service
  * false to use a nock server
  */
-const OPENCENSUS_NETWORK_TESTS =
-    ['true', 'TRUE', '1'].indexOf(process.env.OPENCENSUS_NETWORK_TESTS) > -1;
+const OPENCENSUS_NETWORK_TESTS = process.env.OPENCENSUS_NETWORK_TESTS;
 
 /** Default options for zipkin tests */
 const zipkinOptions = {

packages/opencensus-exporter-zipkin/tsconfig.json

@@ -6,7 +6,8 @@
     "pretty": true,
     "module": "commonjs",
     "target": "es6",
-    "strictNullChecks": false
+    "strictNullChecks": true,
+    "noUnusedLocals": true
   },
   "include": [
     "src/**/*.ts",
@@ -15,4 +16,4 @@
   "exclude": [
     "node_modules"
   ]
-}
+}