Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit 4714705

Browse files
authored
Fix the exporter-ocagent (#366)
The `exporter-ocagent` had two critical issues which left the exporter unusable: 1. The required grpc proto files were not being referenced correctly (#174) 2. The `ConfigStream` behavior (where the ocagent can send configuration changes down to the client) was not connecting / receiving correctly from the ocagent, causing errors and spamming logs The following changes have been applied to fix the above issues: 1. We now package the proto files for both OpenCensus and the google common proto set into the final `@opencensus/exporter-ocagent` package. The changes mostly reside in the `package.json` configuration. 2. We have removed all references to the `ConfigStream` behavior. This is a breaking change, but the ocagent exporter was not in a usable form previously, so I don't expect there to be any users directly impacted. A few other changes have been included as well: * The default ocagent port has been changed to `55678` to match the default OC Agent/Collector port. * A slight reconnect delay has been added to avoid rapid reconnect attempts. * Updated `grpc` dependency version to `1.18.0`. * Readme / Docs update * Changelog update
1 parent d4f36b0 commit 4714705

File tree

6 files changed

+1615
-499
lines changed

6 files changed

+1615
-499
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ All notable changes to this project will be documented in this file.
88
- Add support for ```tags```, ```status``` and ```annotation``` in Zipkin exporter.
99
- Add support for Binary propagation format.
1010
- Add support for object(```SpanOptions```) as an argument for ```startChildSpan``` function, similar to ```startRootSpan```.
11+
- Add proto files to exporter-ocagent package. Fixes issue [#174](https://github.com/census-instrumentation/opencensus-node/issues/174).
12+
- Remove `ConfigStream` behavior from exporter-ocagent. This was unstable and is not currently supported by any other language instrumentation.
13+
- Change default exporter-ocagent port to `55678` to match the default OC Agent port.
1114

1215
## 0.0.9 - 2019-02-12
1316
- Add Metrics API.

packages/opencensus-exporter-ocagent/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# OpenCensus Agent Exporter for Node.js
22
[![Gitter chat][gitter-image]][gitter-url]
33

4-
OpenCensus Agent Exporter allows the user to send collected traces with OpenCensus Node.js to the OpenCensus Agent, and to receive tracer configuration changes from the OpenCensus Agent.
4+
OpenCensus Agent Exporter allows the user to send collected traces with OpenCensus Node.js to the OpenCensus Agent or Collector.
55

66
This project is still at an early stage of development, it's subject to change.
77

@@ -59,7 +59,7 @@ Option | Type | Description
5959
----------------|-------------------------|-
6060
`serviceName` | string | Name of the service. Defaults to `Anonymous Service`.
6161
`host` | string | Host or ip of the agent. Defaults to `localhost`.
62-
`port` | number | Port of the agent. Defaults to `50051`.
62+
`port` | number | Port of the agent. Defaults to `55678`.
6363
`credentials` | grpc.ChannelCredentials | Credentials to use for grpc connection to agent. Defaults to `grpc.credentials.createInsecure()`.
6464
`attributes` | {[key: string]: string} | Map of key-value pairs to associate with the Node.
6565
`bufferSize` | number | Maximum size of the span buffer.

0 commit comments

Comments
 (0)