Skip to content

Some description in advanced configurations is wrong #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lanius-collaris opened this issue Apr 7, 2025 · 1 comment
Open

Some description in advanced configurations is wrong #1919

Lanius-collaris opened this issue Apr 7, 2025 · 1 comment

Comments

@Lanius-collaris
Copy link

Lanius-collaris commented Apr 7, 2025

https://github.com/hussainmohd-a/rethink-app/blob/c50dc87d1d5717011c9f86081f14d73be4ee7156/app/src/main/res/values/strings.xml#L1594

                                      E
   +------+                 +------+  x
   |  Y1  |                 |  Y2  |  t
   +--+---+                 +---+--+  e
      | Y1:y1            Y2:y2  |     r
      +----------+   +----------+     n
                 |   |                a
         X1':x1' |   | X2':x2'        l
              +--+---+-+
   ...........|   NAT  |...............
              +--+---+-+              I
                 |   |                n
             X:x |   | X:x            t
                ++---++               e
                |  X  |               r
                +-----+               n
                                      a
                                      l

                         Address and Port Mapping

"Endpoint-Independent Mapping" means "reuse the port mapping for subsequent packets sent from the same internal IP address and port (X:x) to any external IP address and port. Specifically, X1':x1' equals X2':x2' for all values of Y2:y2", not "Allow incoming packets to be forwarded to the same endpoint, regardless of the source IP address"
https://www.rfc-editor.org/rfc/rfc4787.html#section-4.1

https://github.com/hussainmohd-a/rethink-app/blob/c50dc87d1d5717011c9f86081f14d73be4ee7156/app/src/main/res/values/strings.xml#L1600
Go's net module enables TCP keepalive by default, rethink APP's "TCP keep alive" option increases the interval (from 15 s to 600 s).
See golang/go#48622

@ignoramous
Copy link
Collaborator

Thanks.

All new labels will be rewritten before release. The current ones on the dev branch you see are a placeholder.

Also, think the label attempts to describe Endpoint-Independent Filtering (EIF), instead (which firestack attempts to implement, but it doesn't yet work).

[EIF] ... sending packets from the internal side of the NAT to any external IP address is sufficient to allow any packets back to the internal endpoint.

Go's net module enables TCP keepalive by default, rethink APP's "TCP keep alive" option increases the interval (from 15 s to 600 s).

Interesting. firestack should be disabling TCP keepalive instead of leaving it at Go's (aggressive) default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants