Merge pull request open-telemetry#5 from celian-garcia/fix/no-empty-filter

celian-garcia · web-flow · commit e26d1521474d · 2024-12-03T15:20:38.000+01:00
fix: don't send empty filter to the Azure API
diff --git a/receiver/azuremonitorreceiver/scraper_batch.go b/receiver/azuremonitorreceiver/scraper_batch.go
@@ -503,7 +503,7 @@ func newQueryResourcesOptions(
 	splitByDimensions bool,
 ) azmetrics.QueryResourcesOptions {
 	var filter *string
-	if splitByDimensions {
+	if splitByDimensions && len(dimensionsStr) > 0 {
 		filter = newMetricsQueryFilterFromDimensions(strings.Split(dimensionsStr, ","))
 	}
 	return azmetrics.QueryResourcesOptions{

Original file line number	Diff line number	Diff line change
`@@ -503,7 +503,7 @@ func newQueryResourcesOptions(`
`503`	`503`	`splitByDimensions bool,`
`504`	`504`	`) azmetrics.QueryResourcesOptions {`
`505`	`505`	`var filter *string`
`506`		`- if splitByDimensions {`
	`506`	`+ if splitByDimensions && len(dimensionsStr) > 0 {`
`507`	`507`	`filter = newMetricsQueryFilterFromDimensions(strings.Split(dimensionsStr, ","))`
`508`	`508`	`}`
`509`	`509`	`return azmetrics.QueryResourcesOptions{`