Skip to content

⬆️ require pybind11 >= 2.13.5 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024
Merged

⬆️ require pybind11 >= 2.13.5 #424

merged 2 commits into from
Sep 5, 2024

Conversation

burgholzer
Copy link
Member

Description

This small PR updates the requirement on pybind11 to 2.13.5 which contains a fix for some relative paths that could trip up compilers.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Sep 5, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file python Pull requests that update Python code fix Anything related to bugfixes labels Sep 5, 2024
@burgholzer burgholzer enabled auto-merge (squash) September 5, 2024 11:58
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.3%. Comparing base (15a0c7c) to head (279aded).
Report is 62 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #424   +/-   ##
=====================================
  Coverage   92.3%   92.3%           
=====================================
  Files         37      37           
  Lines       2721    2721           
  Branches     305     305           
=====================================
  Hits        2513    2513           
  Misses       208     208           
Flag Coverage Δ
cpp 94.1% <ø> (ø)
python 87.4% <ø> (ø)

see 3 files with indirect coverage changes

@burgholzer burgholzer merged commit d7e1238 into main Sep 5, 2024
34 checks passed
@burgholzer burgholzer deleted the pybind11 branch September 5, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file fix Anything related to bugfixes python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant