Skip to content

🐛 properly initialize rootEdge #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2024
Merged

🐛 properly initialize rootEdge #405

merged 1 commit into from
Jul 22, 2024

Conversation

burgholzer
Copy link
Member

Description

Fixes #404

The rootEdge was not properly initialized, which led to rootEdge.w.r == rootEdge.w.i == nullptr and henceforth a nullptr dereference in the RealNumber::val method.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added c++ Anything related to C++ code fix Anything related to bugfixes labels Jul 22, 2024
@burgholzer burgholzer self-assigned this Jul 22, 2024
@burgholzer burgholzer mentioned this pull request Jul 22, 2024
Closed
@burgholzer burgholzer enabled auto-merge (squash) July 22, 2024 14:50
@burgholzer burgholzer merged commit ef62ef2 into main Jul 22, 2024
34 checks passed
@burgholzer burgholzer deleted the fix-segfault-get_vector branch July 22, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@burgholzer burgholzer

Labels
c++ Anything related to C++ code fix Anything related to bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 segfault in M1 mac
1 participant
@burgholzer