Skip to content

🚸 add configurable repo owner for mqt-core dependency #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

burgholzer
Copy link
Member

Description

This small PR adds a configuration option for the owner of the mqt-core dependency that is fetched via FetchContent. This should make it easier to point to forks of mqt-core.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Jun 24, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file c++ Anything related to C++ code usability Anything related to usability labels Jun 24, 2024
@burgholzer burgholzer enabled auto-merge (squash) June 24, 2024 14:39
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.5%. Comparing base (cfd2f65) to head (b428147).
Report is 62 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #392     +/-   ##
=======================================
- Coverage   92.5%   92.5%   -0.1%     
=======================================
  Files         37      37             
  Lines       2561    2561             
  Branches     310     310             
=======================================
- Hits        2371    2370      -1     
- Misses       190     191      +1     
Flag Coverage Δ
cpp 94.5% <ø> (-0.1%) ⬇️
python 87.3% <ø> (ø)

see 1 file with indirect coverage changes

@burgholzer burgholzer merged commit 59a4b73 into main Jun 25, 2024
34 checks passed
@burgholzer burgholzer deleted the better-management-for-mqt-forks branch June 25, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file usability Anything related to usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant