🚨 Fix new warnings revealed by clang-tidy 18

[burgholzer]

Description

This PR aims to fix all the new warnings that were introduced in clang-tidy versions 18, which have been enabled with the switch to the [email protected].

Checklist:

• The pull request only contains commits that are related to it.
• I have added appropriate tests and documentation.
• I have made sure that all CI jobs on GitHub pass.
• The pull request introduces no new warnings and follows the project's style guidelines.

[codecov]

Codecov Report

Attention: Patch coverage is 94.50437% with 107 lines in your changes missing coverage. Please review.

Project coverage is 92.6%. Comparing base (2b0b4c5) to head (16f744a).
Report is 53 commits behind head on main.

Files with missing lines	Patch %	Lines
src/PathSimulator.cpp	88.6%	32 Missing ⚠️
src/ShorFastSimulator.cpp	94.5%	15 Missing ⚠️
src/ShorSimulator.cpp	95.2%	13 Missing ⚠️
src/Simulator.cpp	93.2%	13 Missing ⚠️
src/CircuitSimulator.cpp	90.8%	12 Missing ⚠️
src/HybridSchrodingerFeynmanSimulator.cpp	97.6%	5 Missing ⚠️
include/HybridSchrodingerFeynmanSimulator.hpp	87.5%	4 Missing ⚠️
include/PathSimulator.hpp	95.4%	4 Missing ⚠️
include/Simulator.hpp	91.4%	4 Missing ⚠️
src/StochasticNoiseSimulator.cpp	96.0%	4 Missing ⚠️
... and 1 more

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #381     +/-   ##
=======================================
+ Coverage   92.5%   92.6%   +0.1%     
=======================================
  Files         37      37             
  Lines       2561    2726    +165     
  Branches     310     306      -4     
=======================================
+ Hits        2371    2527    +156     
- Misses       190     199      +9     

Flag	Coverage Δ
cpp	94.6% <94.5%> (-0.1%)	⬇️
python	87.3% <ø> (ø)

Files with missing lines	Coverage Δ
include/CircuitSimulator.hpp	100.0% <100.0%> (ø)
include/DeterministicNoiseSimulator.hpp	100.0% <100.0%> (ø)
include/ShorFastSimulator.hpp	100.0% <100.0%> (ø)
include/ShorSimulator.hpp	100.0% <100.0%> (ø)
include/StochasticNoiseSimulator.hpp	100.0% <100.0%> (ø)
include/UnitarySimulator.hpp	100.0% <100.0%> (ø)
src/DeterministicNoiseSimulator.cpp	100.0% <100.0%> (ø)
src/GroverSimulator.cpp	100.0% <100.0%> (ø)
src/UnitarySimulator.cpp	100.0% <100.0%> (ø)
include/GroverSimulator.hpp	96.5% <96.1%> (+0.1%)	⬆️
... and 10 more