Skip to content

👽 adjust to latest mqt-core changes #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

burgholzer
Copy link
Member

Description

This PR adjust the codebase to the latest changes from mqt-core (specifically munich-quantum-toolkit/core#491).
Note that this merely applies the minimal changes necessary to run the project with the latest version.
A proper cleanup of the noise-aware simulators is scheduled to arrive with #321.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code c++ Anything related to C++ code labels Feb 14, 2024
@burgholzer burgholzer self-assigned this Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20ec8c4) 92.8% compared to head (4483657) 92.7%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #348     +/-   ##
=======================================
- Coverage   92.8%   92.7%   -0.1%     
=======================================
  Files         35      35             
  Lines       2664    2660      -4     
  Branches     345     345             
=======================================
- Hits        2474    2468      -6     
- Misses       190     192      +2     
Flag Coverage Δ
cpp 94.6% <100.0%> (-0.2%) ⬇️
python 87.7% <ø> (ø)
Files Coverage Δ
include/DeterministicNoiseSimulator.hpp 100.0% <100.0%> (ø)
src/DeterministicNoiseSimulator.cpp 90.6% <100.0%> (-0.6%) ⬇️

... and 2 files with indirect coverage changes

@burgholzer burgholzer merged commit a50b525 into main Feb 14, 2024
@burgholzer burgholzer deleted the adjust-for-mqt-core-changes branch February 14, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant