-
Notifications
You must be signed in to change notification settings - Fork 34
✨ switch to mqt-core
Python package
#336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ffac4c
to
ee41104
Compare
4 tasks
ee41104
to
8209611
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
=======================================
+ Coverage 92.3% 93.9% +1.5%
=======================================
Files 37 37
Lines 2734 2648 -86
Branches 311 301 -10
=======================================
- Hits 2526 2488 -38
+ Misses 208 160 -48
|
a2ef802
to
2d2c358
Compare
4 tasks
61996fd
to
60cd68f
Compare
60cd68f
to
e952e85
Compare
66b69b8
to
bb7ffd3
Compare
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
bb7ffd3
to
ffa4dd7
Compare
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
burgholzer
added a commit
to munich-quantum-toolkit/core
that referenced
this pull request
Mar 4, 2025
…lation (#849) ## Description This pull request adds support for handling empty quantum and classical registers during the translation process from Qiskit to MQT. This update ensures proper translation and eliminates any potential errors caused by empty registers. This has come up while working on munich-quantum-toolkit/ddsim#336 ## Checklist: - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. Signed-off-by: burgholzer <[email protected]>
this has been a burden to maintain and some of the dependencies involved are not mature enough. Given the limited scope of the feature, it is for the best to simply remove it. Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
ffa4dd7
to
646c319
Compare
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
d2b7cae
to
fd95157
Compare
This was referenced Mar 4, 2025
ystade
pushed a commit
to munich-quantum-toolkit/core
that referenced
this pull request
Mar 5, 2025
…lation (#849) ## Description This pull request adds support for handling empty quantum and classical registers during the translation process from Qiskit to MQT. This update ensures proper translation and eliminates any potential errors caused by empty registers. This has come up while working on munich-quantum-toolkit/ddsim#336 ## Checklist: - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. Signed-off-by: burgholzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Anything related to C++ code
dependencies
Pull requests that update a dependency file
extensive-cpp-ci
Adding this label indicates that extensive C++ CI runs should be started for this PR.
extensive-python-ci
Adding this label indicates that extensive Python CI runs should be started for this PR.
github-actions
Pull requests that update GitHub Actions code
major
Part of a major release
packaging
Anything related to Python packaging
pre-commit
Pull requests that update pre-commit checks
python
Pull requests that update Python code
refactor
Anything related to code refactoring
usability
Anything related to usability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the project to use the newly developed
mqt-core
Python package.Any Python package build will only require the
mqt-core
package as a build and runtime dependency and won't have to rely on fetched version of mqt-core any more.Any regular C++ build will still use the
FetchContent
CMake module.The change brings a range of advantages:
load
function ofmqt-core
that allows to load any supported circuit format as input and has better handling for QiskitQuantumCircuit
objects.In addition, this PR updates mqt-ddsim to most of the current best practices within the MQT.
Checklist: