-
Notifications
You must be signed in to change notification settings - Fork 34
✨ Provide access to visualization of simulated DD in Python #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=======================================
- Coverage 92.5% 92.4% -0.1%
=======================================
Files 32 32
Lines 2528 2546 +18
Branches 347 348 +1
=======================================
+ Hits 2339 2355 +16
- Misses 189 191 +2
|
Signed-off-by: burgholzer <[email protected]>
hillmich
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Cpp-Linter Report ✔️No problems need attention. Have any feedback or feature suggestions? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
feature
New feature or request
python
Pull requests that update Python code
usability
Anything related to usability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables Python users of our tool to get access to the Graphviz file for the simulated DD in order to inspect the final decision diagram.
This required very little code changes and should be rather convenient to use as, e.g., illustrated in the new docs section.
Checklist: