Merge branch 'mc-1.21.x' into mc-1.21.y

Author: SquidDev

CONTRIBUTING.md

@@ -88,8 +88,8 @@ You'll first need to [set up a development environment as above](#setting-up-a-d
 
 Once this is set up, you can now run `./gradlew docWebsite`. This generates documentation from our Lua and Java code,
 writing the resulting HTML into `./projects/web/build/site`, which can then be opened in a browser. When iterating on
-documentation, you can instead run `./gradlew docWebsite -t`, which will rebuild documentation every time you change a
-file.
+documentation, you can instead run `./gradlew :web:assemble -x :web:compileTeaVM -t`, which will rebuild documentation
+every time you change a file.
 
 Documentation is built using [illuaminate] which, while not currently documented (somewhat ironic), is largely the same
 as [ldoc][ldoc]. Documentation comments are written in Markdown, though note that we do not support many GitHub-specific

buildSrc/src/main/kotlin/cc/tweaked/gradle/XmlUtil.kt

@@ -58,11 +58,11 @@ junitPlatform = "1.11.4"
 jmh = "1.37"
 
 # Build tools
-cctJavadoc = "1.8.3"
+cctJavadoc = "1.8.4"
 checkstyle = "10.21.2"
 errorProne-core = "2.36.0"
 errorProne-plugin = "4.1.0"
-fabric-loom = "1.9.2"
+fabric-loom = "1.10.3"
 githubRelease = "2.5.2"
 gradleVersions = "0.50.0"
 ideaExt = "1.1.7"
@@ -75,7 +75,7 @@ shadow = "8.3.1"
 spotless = "6.23.3"
 taskTree = "2.1.1"
 teavm = "0.11.0-SQUID.1"
-vanillaExtract = "0.2.0"
+vanillaExtract = "0.2.1"
 versionCatalogUpdate = "0.8.1"
 
 [libraries]

gradle/libs.versions.toml

@@ -51,10 +51,10 @@ public ComponentDetailProvider(DataComponentType<T> component) {
      * This method is always called on the server thread, so it is safe to interact with the world here, but you should
      * take care to avoid long blocking operations as this will stall the server and other computers.
      *
-     * @param data The full details to be returned for this item stack. New properties should be added to this map.
-     * @param item The component to provide details for.
+     * @param data      The full details to be returned for this item stack. New properties should be added to this map.
+     * @param component The component to provide details for.
      */
-    public abstract void provideComponentDetails(Map<? super String, Object> data, T item);
+    public abstract void provideComponentDetails(Map<? super String, Object> data, T component);
 
     @Override
     public final void provideDetails(Map<? super String, Object> data, DataComponentHolder holder) {

projects/common-api/src/main/java/dan200/computercraft/api/detail/ComponentDetailProvider.java

@@ -12,9 +12,9 @@
 import net.irisshaders.iris.api.v0.IrisApi;
 import net.irisshaders.iris.api.v0.IrisTextVertexSink;
 import net.minecraft.client.renderer.LightTexture;
+import org.jspecify.annotations.Nullable;
 import org.lwjgl.system.MemoryUtil;
 
-import javax.annotation.Nullable;
 import java.nio.ByteBuffer;
 import java.util.Optional;
 

projects/common/src/client/java/dan200/computercraft/client/integration/IrisShaderMod.java

@@ -12,6 +12,7 @@
 import dan200.computercraft.client.render.text.FixedWidthFontRenderer;
 import dan200.computercraft.core.terminal.Terminal;
 import dan200.computercraft.core.util.Colour;
+import dan200.computercraft.shared.ModRegistry;
 import dan200.computercraft.shared.lectern.CustomLecternBlockEntity;
 import dan200.computercraft.shared.media.items.PrintoutData;
 import dan200.computercraft.shared.media.items.PrintoutItem;
@@ -59,9 +60,9 @@ public void render(CustomLecternBlockEntity lectern, float partialTick, PoseStac
         poseStack.translate(0, -0.125f, 0);
 
         var item = lectern.getItem();
-        if (item.getItem() instanceof PrintoutItem printout) {
+        if (item.getItem() instanceof PrintoutItem) {
             var vertexConsumer = LecternPrintoutModel.MATERIAL.buffer(buffer, RenderType::entitySolid);
-            if (printout.getType() == PrintoutItem.Type.BOOK) {
+            if (item.is(ModRegistry.Items.PRINTED_BOOK.get())) {
                 printoutModel.renderBook(poseStack, vertexConsumer, packedLight, packedOverlay);
             } else {
                 printoutModel.renderPages(poseStack, vertexConsumer, packedLight, packedOverlay, PrintoutData.getOrEmpty(item).pages());

projects/common/src/client/java/dan200/computercraft/client/render/CustomLecternRenderer.java

@@ -12,8 +12,7 @@
 import net.minecraft.client.renderer.entity.state.ItemFrameRenderState;
 import net.minecraft.world.entity.decoration.ItemFrame;
 import net.minecraft.world.item.ItemStack;
-
-import javax.annotation.Nullable;
+import org.jspecify.annotations.Nullable;
 
 /**
  * Additional render state attached to a {@link ItemFrameRenderState}.

projects/common/src/client/java/dan200/computercraft/client/render/ExtendedItemFrameRenderState.java

@@ -13,7 +13,10 @@
 import dan200.computercraft.shared.peripheral.monitor.MonitorWatcher;
 import dan200.computercraft.shared.util.DropConsumer;
 import dan200.computercraft.shared.util.TickScheduler;
+import net.minecraft.core.component.DataComponentType;
+import net.minecraft.core.component.DataComponents;
 import net.minecraft.core.registries.Registries;
+import net.minecraft.network.chat.Component;
 import net.minecraft.resources.ResourceKey;
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.server.MinecraftServer;
@@ -25,9 +28,8 @@
 import net.minecraft.world.InteractionResult;
 import net.minecraft.world.entity.Entity;
 import net.minecraft.world.entity.player.Player;
-import net.minecraft.world.item.CreativeModeTab;
-import net.minecraft.world.item.CreativeModeTabs;
-import net.minecraft.world.item.ItemStack;
+import net.minecraft.world.item.*;
+import net.minecraft.world.item.component.TooltipProvider;
 import net.minecraft.world.level.Level;
 import net.minecraft.world.level.block.Blocks;
 import net.minecraft.world.level.block.LecternBlock;
@@ -40,8 +42,10 @@
 import net.minecraft.world.phys.BlockHitResult;
 import org.jspecify.annotations.Nullable;
 
+import java.util.List;
 import java.util.Set;
 import java.util.function.BiConsumer;
+import java.util.function.Consumer;
 
 /**
  * Event listeners for server/common code.
@@ -163,4 +167,42 @@ public static void onBuildCreativeTab(ResourceKey<CreativeModeTab> key, Creative
             out.accept(ModRegistry.Items.COMPUTER_COMMAND.get());
         }
     }
+
+    public static void onItemTooltip(ItemStack stack, Item.TooltipContext context, TooltipFlag flags, List<Component> out) {
+        var appender = new TooltipAppender(out);
+        addToTooltip(stack, ModRegistry.DataComponents.PRINTOUT.get(), context, appender, flags);
+        addToTooltip(stack, ModRegistry.DataComponents.TREASURE_DISK.get(), context, appender, flags);
+
+        // Disk and computer IDs require some conditional logic, so we don't bother using TooltipProvider.
+
+        var diskId = stack.get(ModRegistry.DataComponents.DISK_ID.get());
+        if (diskId != null && flags.isAdvanced()) diskId.addToTooltip("gui.computercraft.tooltip.disk_id", appender);
+
+        var computerId = stack.get(ModRegistry.DataComponents.COMPUTER_ID.get());
+        if (computerId != null && (flags.isAdvanced() || !stack.has(DataComponents.CUSTOM_NAME))) {
+            computerId.addToTooltip("gui.computercraft.tooltip.computer_id", appender);
+        }
+    }
+
+    /**
+     * Inserts additional tooltip items directly after the custom name, rather than at the very end.
+     */
+    private static final class TooltipAppender implements Consumer<Component> {
+        private final List<Component> out;
+        private int index = 1;
+
+        private TooltipAppender(List<Component> out) {
+            this.out = out;
+        }
+
+        @Override
+        public void accept(Component component) {
+            out.add(index++, component);
+        }
+    }
+
+    private static <T extends TooltipProvider> void addToTooltip(ItemStack stack, DataComponentType<T> component, Item.TooltipContext context, Consumer<Component> out, TooltipFlag flags) {
+        var provider = stack.get(component);
+        if (provider != null) provider.addToTooltip(context, out, flags);
+    }
 }

projects/common/src/main/java/dan200/computercraft/shared/CommonHooks.java

@@ -35,8 +35,6 @@
 import dan200.computercraft.shared.computer.core.ComputerFamily;
 import dan200.computercraft.shared.computer.core.ServerComputer;
 import dan200.computercraft.shared.computer.inventory.ComputerMenuWithoutInventory;
-import dan200.computercraft.shared.computer.items.CommandComputerItem;
-import dan200.computercraft.shared.computer.items.ComputerItem;
 import dan200.computercraft.shared.computer.items.ServerComputerReference;
 import dan200.computercraft.shared.config.Config;
 import dan200.computercraft.shared.data.BlockNamedEntityLootCondition;
@@ -114,10 +112,7 @@
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.world.flag.FeatureFlags;
 import net.minecraft.world.inventory.MenuType;
-import net.minecraft.world.item.BlockItem;
-import net.minecraft.world.item.CreativeModeTab;
-import net.minecraft.world.item.Item;
-import net.minecraft.world.item.ItemStack;
+import net.minecraft.world.item.*;
 import net.minecraft.world.item.component.DyedItemColor;
 import net.minecraft.world.item.crafting.CustomRecipe;
 import net.minecraft.world.item.crafting.Recipe;
@@ -291,9 +286,9 @@ private static <B extends Block, I extends Item> RegistryEntry<I> ofBlock(Regist
             return register(parent.id().getPath(), p -> supplier.apply(parent.get(), p), properties().useBlockDescriptionPrefix());
         }
 
-        public static final RegistryEntry<ComputerItem> COMPUTER_NORMAL = ofBlock(Blocks.COMPUTER_NORMAL, ComputerItem::new);
-        public static final RegistryEntry<ComputerItem> COMPUTER_ADVANCED = ofBlock(Blocks.COMPUTER_ADVANCED, ComputerItem::new);
-        public static final RegistryEntry<ComputerItem> COMPUTER_COMMAND = ofBlock(Blocks.COMPUTER_COMMAND, CommandComputerItem::new);
+        public static final RegistryEntry<BlockItem> COMPUTER_NORMAL = ofBlock(Blocks.COMPUTER_NORMAL, BlockItem::new);
+        public static final RegistryEntry<BlockItem> COMPUTER_ADVANCED = ofBlock(Blocks.COMPUTER_ADVANCED, BlockItem::new);
+        public static final RegistryEntry<GameMasterBlockItem> COMPUTER_COMMAND = ofBlock(Blocks.COMPUTER_COMMAND, GameMasterBlockItem::new);
 
         public static final RegistryEntry<PocketComputerItem> POCKET_COMPUTER_NORMAL = register("pocket_computer_normal",
             p -> new PocketComputerItem(p, ComputerFamily.NORMAL), properties().stacksTo(1));
@@ -305,19 +300,19 @@ private static <B extends Block, I extends Item> RegistryEntry<I> ofBlock(Regist
 
         public static final RegistryEntry<DiskItem> DISK =
             register("disk", DiskItem::new, properties().stacksTo(1));
-        public static final RegistryEntry<TreasureDiskItem> TREASURE_DISK =
-            register("treasure_disk", TreasureDiskItem::new, properties().stacksTo(1));
+        public static final RegistryEntry<DiskItem> TREASURE_DISK =
+            register("treasure_disk", DiskItem::new, properties().stacksTo(1));
 
         private static Item.Properties printoutProperties() {
             return properties().stacksTo(1).component(DataComponents.PRINTOUT.get(), PrintoutData.EMPTY);
         }
 
         public static final RegistryEntry<PrintoutItem> PRINTED_PAGE = register("printed_page",
-            p -> new PrintoutItem(p, PrintoutItem.Type.PAGE), Items::printoutProperties);
+            PrintoutItem::new, Items::printoutProperties);
         public static final RegistryEntry<PrintoutItem> PRINTED_PAGES = register("printed_pages",
-            p -> new PrintoutItem(p, PrintoutItem.Type.PAGES), Items::printoutProperties);
+            PrintoutItem::new, Items::printoutProperties);
         public static final RegistryEntry<PrintoutItem> PRINTED_BOOK = register("printed_book",
-            p -> new PrintoutItem(p, PrintoutItem.Type.BOOK), Items::printoutProperties);
+            PrintoutItem::new, Items::printoutProperties);
 
         public static final RegistryEntry<BlockItem> SPEAKER = ofBlock(Blocks.SPEAKER, BlockItem::new);
         public static final RegistryEntry<BlockItem> DISK_DRIVE = ofBlock(Blocks.DISK_DRIVE, BlockItem::new);
@@ -344,20 +339,13 @@ private static <T> RegistryEntry<DataComponentType<T>> register(String name, Una
 
         /**
          * The id of a computer.
-         *
-         * @see ComputerItem
-         * @see PocketComputerItem
          */
         public static final RegistryEntry<DataComponentType<NonNegativeId>> COMPUTER_ID = register("computer_id", b -> b
             .persistent(NonNegativeId.CODEC).networkSynchronized(NonNegativeId.STREAM_CODEC)
         );
 
         /**
          * The storage capacity of a computer or disk.
-         *
-         * @see ComputerItem
-         * @see PocketComputerItem
-         * @see DiskItem
          */
         public static final RegistryEntry<DataComponentType<StorageCapacity>> STORAGE_CAPACITY = register("storage_capacity", b -> b
             .persistent(StorageCapacity.CODEC).networkSynchronized(StorageCapacity.STREAM_CODEC)
@@ -426,18 +414,13 @@ private static <T> RegistryEntry<DataComponentType<T>> register(String name, Una
 
         /**
          * Information about a treasure disk's mount.
-         *
-         * @see TreasureDiskItem
-         * @see TreasureDisk
          */
         public static final RegistryEntry<DataComponentType<TreasureDisk>> TREASURE_DISK = register("treasure_disk", b -> b
             .persistent(TreasureDisk.CODEC).networkSynchronized(TreasureDisk.STREAM_CODEC)
         );
 
         /**
          * The id of a disk.
-         *
-         * @see DiskItem
          */
         public static final RegistryEntry<DataComponentType<NonNegativeId>> DISK_ID = register("disk_id", b -> b
             .persistent(NonNegativeId.CODEC).networkSynchronized(NonNegativeId.STREAM_CODEC)

projects/common/src/main/java/dan200/computercraft/shared/ModRegistry.java

@@ -9,8 +9,10 @@
 import dan200.computercraft.shared.platform.PlatformHelper;
 import dan200.computercraft.shared.platform.RegistryEntry;
 import dan200.computercraft.shared.util.BlockEntityHelpers;
+import net.minecraft.Util;
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Direction;
+import net.minecraft.core.component.DataComponentMap;
 import net.minecraft.util.RandomSource;
 import net.minecraft.world.InteractionResult;
 import net.minecraft.world.entity.player.Player;
@@ -65,12 +67,6 @@ protected int getDirectSignal(BlockState state, BlockGetter world, BlockPos pos,
         return computer.getRedstoneOutput(localSide);
     }
 
-    private ItemStack getItem(AbstractComputerBlockEntity tile) {
-        var stack = new ItemStack(this);
-        stack.applyComponents(tile.collectComponents());
-        return stack;
-    }
-
     @Override
     protected int getSignal(BlockState state, BlockGetter world, BlockPos pos, Direction incomingSide) {
         return getDirectSignal(state, world, pos, incomingSide);
@@ -90,12 +86,11 @@ public int getBundledRedstoneOutput(Level world, BlockPos pos, Direction side) {
 
     @Override
     public ItemStack getCloneItemStack(LevelReader world, BlockPos pos, BlockState state, boolean includeData) {
+        var stack = super.getCloneItemStack(world, pos, state, includeData);
         if (world.getBlockEntity(pos) instanceof AbstractComputerBlockEntity computer) {
-            var result = getItem(computer);
-            if (!result.isEmpty()) return result;
+            stack.applyComponents(computer.collectComponents());
         }
-
-        return super.getCloneItemStack(world, pos, state, includeData);
+        return stack;
     }
 
     @Override
@@ -121,7 +116,10 @@ protected InteractionResult useWithoutItem(BlockState state, Level level, BlockP
                 var serverComputer = computer.createServerComputer();
                 serverComputer.turnOn();
 
-                PlatformHelper.get().openMenu(player, computer.getName(), computer, new ComputerContainerData(serverComputer, getItem(computer)));
+                var stack = new ItemStack(this);
+                stack.applyComponents(Util.make(DataComponentMap.builder(), computer::collectSafeComponents).build());
+
+                PlatformHelper.get().openMenu(player, computer.getName(), computer, new ComputerContainerData(serverComputer, stack));
             }
             return InteractionResult.SUCCESS;
         }

projects/common/src/main/java/dan200/computercraft/shared/computer/blocks/AbstractComputerBlock.java

@@ -5,6 +5,7 @@
 package dan200.computercraft.shared.computer.blocks;
 
 import com.google.common.base.Strings;
+import com.google.errorprone.annotations.OverridingMethodsMustInvokeSuper;
 import dan200.computercraft.api.ComputerCraftAPI;
 import dan200.computercraft.api.peripheral.IPeripheral;
 import dan200.computercraft.core.computer.ComputerSide;
@@ -185,10 +186,20 @@ protected void applyImplicitComponents(DataComponentInput component) {
     @Override
     protected void collectImplicitComponents(DataComponentMap.Builder builder) {
         super.collectImplicitComponents(builder);
+        collectSafeComponents(builder);
+        if (lockCode != LockCode.NO_LOCK) builder.set(DataComponents.LOCK, lockCode);
+    }
+
+    /**
+     * Collect components that are safe to share with the client.
+     *
+     * @param builder The component builder.
+     */
+    @OverridingMethodsMustInvokeSuper
+    protected void collectSafeComponents(DataComponentMap.Builder builder) {
         builder.set(ModRegistry.DataComponents.COMPUTER_ID.get(), NonNegativeId.of(computerID));
         builder.set(DataComponents.CUSTOM_NAME, label == null ? null : Component.literal(label));
         builder.set(ModRegistry.DataComponents.STORAGE_CAPACITY.get(), storageCapacity > 0 ? new StorageCapacity(storageCapacity) : null);
-        if (lockCode != LockCode.NO_LOCK) builder.set(DataComponents.LOCK, lockCode);
     }
 
     @Override

projects/common/src/main/java/dan200/computercraft/shared/computer/blocks/AbstractComputerBlockEntity.java

@@ -16,7 +16,6 @@
  * permission.
  *
  * @param <T> The type of the computer block entity.
- * @see dan200.computercraft.shared.computer.items.CommandComputerItem
  */
 public class CommandComputerBlock<T extends ComputerBlockEntity> extends ComputerBlock<T> implements GameMasterBlock {
     private static final MapCodec<CommandComputerBlock<?>> CODEC = RecordCodecBuilder.mapCodec(instance -> instance.group(