Skip to content

Commit 39703a1

Browse files
horenmarhorenmar
committed
Fixup missing approvals
1 parent f387caf commit 39703a1

18 files changed

+148
-20
lines changed

‎tests/SelfTest/Baselines/automake.sw.approved.txt

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ Nor would this
2626
:test-result: PASS #2152 - ULP checks between differently signed values were wrong - double
2727
:test-result: PASS #2152 - ULP checks between differently signed values were wrong - float
2828
:test-result: XFAIL #2615 - Throwing in constructor generator fails test case but does not abort
29+
:test-result: PASS #2944 - Stringifying dates before 1970 should not crash
2930
:test-result: XFAIL #748 - captures with unexpected exceptions
3031
:test-result: PASS #809
3132
:test-result: PASS #833

‎tests/SelfTest/Baselines/automake.sw.multi.approved.txt

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
:test-result: PASS #2152 - ULP checks between differently signed values were wrong - double
2525
:test-result: PASS #2152 - ULP checks between differently signed values were wrong - float
2626
:test-result: XFAIL #2615 - Throwing in constructor generator fails test case but does not abort
27+
:test-result: PASS #2944 - Stringifying dates before 1970 should not crash
2728
:test-result: XFAIL #748 - captures with unexpected exceptions
2829
:test-result: PASS #809
2930
:test-result: PASS #833

‎tests/SelfTest/Baselines/compact.sw.approved.txt

+6-2
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,10 @@ Matchers.tests.cpp:<line number>: passed: smallest_non_zero, !WithinULP( -smalle
8585
Matchers.tests.cpp:<line number>: passed: smallest_non_zero, WithinULP( -smallest_non_zero, 2 ) for: 0.0f is within 2 ULPs of -1.40129846e-45f ([-4.20389539e-45, 1.40129846e-45])
8686
Matchers.tests.cpp:<line number>: passed: smallest_non_zero, !WithinULP( -smallest_non_zero, 1 ) for: 0.0f not is within 1 ULPs of -1.40129846e-45f ([-2.80259693e-45, -0.00000000e+00])
8787
Generators.tests.cpp:<line number>: failed: unexpected exception with message: 'failure to init'
88+
ToString.tests.cpp:<line number>: passed: converted_post == "{iso8601-timestamp}" for: "{iso8601-timestamp}"
89+
==
90+
"{iso8601-timestamp}"
91+
ToString.tests.cpp:<line number>: passed: converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) for: "{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime from provided timepoint has failed. This happens e.g. with pre-1970 dates using Microsoft libc" )
8892
Exception.tests.cpp:<line number>: failed: unexpected exception with message: 'answer := 42' with 1 message: 'expected exception'
8993
Exception.tests.cpp:<line number>: failed: unexpected exception with message: 'answer := 42'; expression was: thisThrows() with 1 message: 'expected exception'
9094
Exception.tests.cpp:<line number>: passed: thisThrows() with 1 message: 'answer := 42'
@@ -2854,7 +2858,7 @@ InternalBenchmark.tests.cpp:<line number>: passed: med == 18. for: 18.0 == 18.0
28542858
InternalBenchmark.tests.cpp:<line number>: passed: q3 == 23. for: 23.0 == 23.0
28552859
Misc.tests.cpp:<line number>: passed:
28562860
Misc.tests.cpp:<line number>: passed:
2857-
test cases: 419 | 313 passed | 86 failed | 6 skipped | 14 failed as expected
2858-
assertions: 2269 | 2087 passed | 147 failed | 35 failed as expected
2861+
test cases: 420 | 314 passed | 86 failed | 6 skipped | 14 failed as expected
2862+
assertions: 2271 | 2089 passed | 147 failed | 35 failed as expected
28592863

28602864

‎tests/SelfTest/Baselines/compact.sw.multi.approved.txt

+6-2
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ Matchers.tests.cpp:<line number>: passed: smallest_non_zero, !WithinULP( -smalle
8383
Matchers.tests.cpp:<line number>: passed: smallest_non_zero, WithinULP( -smallest_non_zero, 2 ) for: 0.0f is within 2 ULPs of -1.40129846e-45f ([-4.20389539e-45, 1.40129846e-45])
8484
Matchers.tests.cpp:<line number>: passed: smallest_non_zero, !WithinULP( -smallest_non_zero, 1 ) for: 0.0f not is within 1 ULPs of -1.40129846e-45f ([-2.80259693e-45, -0.00000000e+00])
8585
Generators.tests.cpp:<line number>: failed: unexpected exception with message: 'failure to init'
86+
ToString.tests.cpp:<line number>: passed: converted_post == "{iso8601-timestamp}" for: "{iso8601-timestamp}"
87+
==
88+
"{iso8601-timestamp}"
89+
ToString.tests.cpp:<line number>: passed: converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) for: "{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime from provided timepoint has failed. This happens e.g. with pre-1970 dates using Microsoft libc" )
8690
Exception.tests.cpp:<line number>: failed: unexpected exception with message: 'answer := 42' with 1 message: 'expected exception'
8791
Exception.tests.cpp:<line number>: failed: unexpected exception with message: 'answer := 42'; expression was: thisThrows() with 1 message: 'expected exception'
8892
Exception.tests.cpp:<line number>: passed: thisThrows() with 1 message: 'answer := 42'
@@ -2843,7 +2847,7 @@ InternalBenchmark.tests.cpp:<line number>: passed: med == 18. for: 18.0 == 18.0
28432847
InternalBenchmark.tests.cpp:<line number>: passed: q3 == 23. for: 23.0 == 23.0
28442848
Misc.tests.cpp:<line number>: passed:
28452849
Misc.tests.cpp:<line number>: passed:
2846-
test cases: 419 | 313 passed | 86 failed | 6 skipped | 14 failed as expected
2847-
assertions: 2269 | 2087 passed | 147 failed | 35 failed as expected
2850+
test cases: 420 | 314 passed | 86 failed | 6 skipped | 14 failed as expected
2851+
assertions: 2271 | 2089 passed | 147 failed | 35 failed as expected
28482852

28492853

‎tests/SelfTest/Baselines/console.std.approved.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1610,6 +1610,6 @@ due to unexpected exception with message:
16101610
Why would you throw a std::string?
16111611

16121612
===============================================================================
1613-
test cases: 419 | 327 passed | 71 failed | 7 skipped | 14 failed as expected
1614-
assertions: 2252 | 2087 passed | 130 failed | 35 failed as expected
1613+
test cases: 420 | 328 passed | 71 failed | 7 skipped | 14 failed as expected
1614+
assertions: 2254 | 2089 passed | 130 failed | 35 failed as expected
16151615

‎tests/SelfTest/Baselines/console.sw.approved.txt

+22-2
Original file line numberDiff line numberDiff line change
@@ -771,6 +771,26 @@ Generators.tests.cpp:<line number>: FAILED:
771771
due to unexpected exception with message:
772772
failure to init
773773

774+
-------------------------------------------------------------------------------
775+
#2944 - Stringifying dates before 1970 should not crash
776+
-------------------------------------------------------------------------------
777+
ToString.tests.cpp:<line number>
778+
...............................................................................
779+
780+
ToString.tests.cpp:<line number>: PASSED:
781+
REQUIRE( converted_post == "{iso8601-timestamp}" )
782+
with expansion:
783+
"{iso8601-timestamp}"
784+
==
785+
"{iso8601-timestamp}"
786+
787+
ToString.tests.cpp:<line number>: PASSED:
788+
REQUIRE_THAT( converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) )
789+
with expansion:
790+
"{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime
791+
from provided timepoint has failed. This happens e.g. with pre-1970 dates
792+
using Microsoft libc" )
793+
774794
-------------------------------------------------------------------------------
775795
#748 - captures with unexpected exceptions
776796
outside assertions
@@ -19012,6 +19032,6 @@ Misc.tests.cpp:<line number>
1901219032
Misc.tests.cpp:<line number>: PASSED:
1901319033

1901419034
===============================================================================
19015-
test cases: 419 | 313 passed | 86 failed | 6 skipped | 14 failed as expected
19016-
assertions: 2269 | 2087 passed | 147 failed | 35 failed as expected
19035+
test cases: 420 | 314 passed | 86 failed | 6 skipped | 14 failed as expected
19036+
assertions: 2271 | 2089 passed | 147 failed | 35 failed as expected
1901719037

‎tests/SelfTest/Baselines/console.sw.multi.approved.txt

+22-2
Original file line numberDiff line numberDiff line change
@@ -769,6 +769,26 @@ Generators.tests.cpp:<line number>: FAILED:
769769
due to unexpected exception with message:
770770
failure to init
771771

772+
-------------------------------------------------------------------------------
773+
#2944 - Stringifying dates before 1970 should not crash
774+
-------------------------------------------------------------------------------
775+
ToString.tests.cpp:<line number>
776+
...............................................................................
777+
778+
ToString.tests.cpp:<line number>: PASSED:
779+
REQUIRE( converted_post == "{iso8601-timestamp}" )
780+
with expansion:
781+
"{iso8601-timestamp}"
782+
==
783+
"{iso8601-timestamp}"
784+
785+
ToString.tests.cpp:<line number>: PASSED:
786+
REQUIRE_THAT( converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) )
787+
with expansion:
788+
"{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime
789+
from provided timepoint has failed. This happens e.g. with pre-1970 dates
790+
using Microsoft libc" )
791+
772792
-------------------------------------------------------------------------------
773793
#748 - captures with unexpected exceptions
774794
outside assertions
@@ -19001,6 +19021,6 @@ Misc.tests.cpp:<line number>
1900119021
Misc.tests.cpp:<line number>: PASSED:
1900219022

1900319023
===============================================================================
19004-
test cases: 419 | 313 passed | 86 failed | 6 skipped | 14 failed as expected
19005-
assertions: 2269 | 2087 passed | 147 failed | 35 failed as expected
19024+
test cases: 420 | 314 passed | 86 failed | 6 skipped | 14 failed as expected
19025+
assertions: 2271 | 2089 passed | 147 failed | 35 failed as expected
1900619026

‎tests/SelfTest/Baselines/console.swa4.approved.txt

+22-2
Original file line numberDiff line numberDiff line change
@@ -771,6 +771,26 @@ Generators.tests.cpp:<line number>: FAILED:
771771
due to unexpected exception with message:
772772
failure to init
773773

774+
-------------------------------------------------------------------------------
775+
#2944 - Stringifying dates before 1970 should not crash
776+
-------------------------------------------------------------------------------
777+
ToString.tests.cpp:<line number>
778+
...............................................................................
779+
780+
ToString.tests.cpp:<line number>: PASSED:
781+
REQUIRE( converted_post == "{iso8601-timestamp}" )
782+
with expansion:
783+
"{iso8601-timestamp}"
784+
==
785+
"{iso8601-timestamp}"
786+
787+
ToString.tests.cpp:<line number>: PASSED:
788+
REQUIRE_THAT( converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) )
789+
with expansion:
790+
"{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime
791+
from provided timepoint has failed. This happens e.g. with pre-1970 dates
792+
using Microsoft libc" )
793+
774794
-------------------------------------------------------------------------------
775795
#748 - captures with unexpected exceptions
776796
outside assertions
@@ -951,6 +971,6 @@ Condition.tests.cpp:<line number>: FAILED:
951971
CHECK( true != true )
952972

953973
===============================================================================
954-
test cases: 33 | 27 passed | 3 failed | 3 failed as expected
955-
assertions: 102 | 94 passed | 4 failed | 4 failed as expected
974+
test cases: 34 | 28 passed | 3 failed | 3 failed as expected
975+
assertions: 104 | 96 passed | 4 failed | 4 failed as expected
956976

‎tests/SelfTest/Baselines/junit.sw.approved.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<testsuitesloose text artifact
33
>
4-
<testsuite name="<exe-name>" errors="17" failures="130" skipped="12" tests="2281" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
4+
<testsuite name="<exe-name>" errors="17" failures="130" skipped="12" tests="2283" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
55
<properties>
66
<property name="random-seed" value="1"/>
77
<property name="filters" value="&quot;*&quot; ~[!nonportable] ~[!benchmark] ~[approvals]"/>
@@ -59,6 +59,7 @@ failure to init
5959
at Generators.tests.cpp:<line number>
6060
</error>
6161
</testcase>
62+
<testcase classname="<exe-name>.global" name="#2944 - Stringifying dates before 1970 should not crash" time="{duration}" status="run"/>
6263
<testcase classname="<exe-name>.global" name="#748 - captures with unexpected exceptions" time="{duration}" status="run"/>
6364
<testcase classname="<exe-name>.global" name="#748 - captures with unexpected exceptions/outside assertions" time="{duration}" status="run">
6465
<skipped message="TEST_CASE tagged with !mayfail"/>

‎tests/SelfTest/Baselines/junit.sw.multi.approved.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<testsuites>
3-
<testsuite name="<exe-name>" errors="17" failures="130" skipped="12" tests="2281" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
3+
<testsuite name="<exe-name>" errors="17" failures="130" skipped="12" tests="2283" hostname="tbd" time="{duration}" timestamp="{iso8601-timestamp}">
44
<properties>
55
<property name="random-seed" value="1"/>
66
<property name="filters" value="&quot;*&quot; ~[!nonportable] ~[!benchmark] ~[approvals]"/>
@@ -58,6 +58,7 @@ failure to init
5858
at Generators.tests.cpp:<line number>
5959
</error>
6060
</testcase>
61+
<testcase classname="<exe-name>.global" name="#2944 - Stringifying dates before 1970 should not crash" time="{duration}" status="run"/>
6162
<testcase classname="<exe-name>.global" name="#748 - captures with unexpected exceptions" time="{duration}" status="run"/>
6263
<testcase classname="<exe-name>.global" name="#748 - captures with unexpected exceptions/outside assertions" time="{duration}" status="run">
6364
<skipped message="TEST_CASE tagged with !mayfail"/>

‎tests/SelfTest/Baselines/sonarqube.sw.approved.txt

+1
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,7 @@ at AssertionHandler.tests.cpp:<line number>
343343
<testCase name="Parsing tags with non-alphabetical characters is pass-through" duration="{duration}"/>
344344
</file>
345345
<file path="tests/<exe-name>/IntrospectiveTests/ToString.tests.cpp">
346+
<testCase name="#2944 - Stringifying dates before 1970 should not crash" duration="{duration}"/>
346347
<testCase name="Directly creating an EnumInfo" duration="{duration}"/>
347348
<testCase name="Range type with sentinel" duration="{duration}"/>
348349
<testCase name="Stringifying char arrays with statically known sizes - char" duration="{duration}"/>

‎tests/SelfTest/Baselines/sonarqube.sw.multi.approved.txt

+1
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,7 @@ at AssertionHandler.tests.cpp:<line number>
342342
<testCase name="Parsing tags with non-alphabetical characters is pass-through" duration="{duration}"/>
343343
</file>
344344
<file path="tests/<exe-name>/IntrospectiveTests/ToString.tests.cpp">
345+
<testCase name="#2944 - Stringifying dates before 1970 should not crash" duration="{duration}"/>
345346
<testCase name="Directly creating an EnumInfo" duration="{duration}"/>
346347
<testCase name="Range type with sentinel" duration="{duration}"/>
347348
<testCase name="Stringifying char arrays with statically known sizes - char" duration="{duration}"/>

‎tests/SelfTest/Baselines/tap.sw.approved.txt

+5-1
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,10 @@ ok {test-number} - smallest_non_zero, WithinULP( -smallest_non_zero, 2 ) for: 0.
166166
ok {test-number} - smallest_non_zero, !WithinULP( -smallest_non_zero, 1 ) for: 0.0f not is within 1 ULPs of -1.40129846e-45f ([-2.80259693e-45, -0.00000000e+00])
167167
# #2615 - Throwing in constructor generator fails test case but does not abort
168168
not ok {test-number} - unexpected exception with message: 'failure to init'
169+
# #2944 - Stringifying dates before 1970 should not crash
170+
ok {test-number} - converted_post == "{iso8601-timestamp}" for: "{iso8601-timestamp}" == "{iso8601-timestamp}"
171+
# #2944 - Stringifying dates before 1970 should not crash
172+
ok {test-number} - converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) for: "{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime from provided timepoint has failed. This happens e.g. with pre-1970 dates using Microsoft libc" )
169173
# #748 - captures with unexpected exceptions
170174
not ok {test-number} - unexpected exception with message: 'answer := 42' with 1 message: 'expected exception'
171175
# #748 - captures with unexpected exceptions
@@ -4567,5 +4571,5 @@ ok {test-number} - q3 == 23. for: 23.0 == 23.0
45674571
ok {test-number} -
45684572
# xmlentitycheck
45694573
ok {test-number} -
4570-
1..2281
4574+
1..2283
45714575

‎tests/SelfTest/Baselines/tap.sw.multi.approved.txt

+5-1
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,10 @@ ok {test-number} - smallest_non_zero, WithinULP( -smallest_non_zero, 2 ) for: 0.
164164
ok {test-number} - smallest_non_zero, !WithinULP( -smallest_non_zero, 1 ) for: 0.0f not is within 1 ULPs of -1.40129846e-45f ([-2.80259693e-45, -0.00000000e+00])
165165
# #2615 - Throwing in constructor generator fails test case but does not abort
166166
not ok {test-number} - unexpected exception with message: 'failure to init'
167+
# #2944 - Stringifying dates before 1970 should not crash
168+
ok {test-number} - converted_post == "{iso8601-timestamp}" for: "{iso8601-timestamp}" == "{iso8601-timestamp}"
169+
# #2944 - Stringifying dates before 1970 should not crash
170+
ok {test-number} - converted_pre, Equals( "{iso8601-timestamp}" ) || Equals( "gmtime from provided timepoint has failed. This " "happens e.g. with pre-1970 dates using Microsoft libc" ) for: "{iso8601-timestamp}" ( equals: "{iso8601-timestamp}" or equals: "gmtime from provided timepoint has failed. This happens e.g. with pre-1970 dates using Microsoft libc" )
167171
# #748 - captures with unexpected exceptions
168172
not ok {test-number} - unexpected exception with message: 'answer := 42' with 1 message: 'expected exception'
169173
# #748 - captures with unexpected exceptions
@@ -4556,5 +4560,5 @@ ok {test-number} - q3 == 23. for: 23.0 == 23.0
45564560
ok {test-number} -
45574561
# xmlentitycheck
45584562
ok {test-number} -
4559-
1..2281
4563+
1..2283
45604564

‎tests/SelfTest/Baselines/teamcity.sw.approved.txt

+2
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@
5555
##teamcity[testStarted name='#2615 - Throwing in constructor generator fails test case but does not abort']
5656
##teamcity[testIgnored name='#2615 - Throwing in constructor generator fails test case but does not abort' message='Generators.tests.cpp:<line number>|n...............................................................................|n|nGenerators.tests.cpp:<line number>|nunexpected exception with message:|n "failure to init"- failure ignore as test marked as |'ok to fail|'|n']
5757
##teamcity[testFinished name='#2615 - Throwing in constructor generator fails test case but does not abort' duration="{duration}"]
58+
##teamcity[testStarted name='#2944 - Stringifying dates before 1970 should not crash']
59+
##teamcity[testFinished name='#2944 - Stringifying dates before 1970 should not crash' duration="{duration}"]
5860
##teamcity[testStarted name='#748 - captures with unexpected exceptions']
5961
##teamcity[testIgnored name='#748 - captures with unexpected exceptions' message='-------------------------------------------------------------------------------|noutside assertions|n-------------------------------------------------------------------------------|nException.tests.cpp:<line number>|n...............................................................................|n|nException.tests.cpp:<line number>|nunexpected exception with messages:|n "answer := 42"|n "expected exception"- failure ignore as test marked as |'ok to fail|'|n']
6062
##teamcity[testIgnored name='#748 - captures with unexpected exceptions' message='-------------------------------------------------------------------------------|ninside REQUIRE_NOTHROW|n-------------------------------------------------------------------------------|nException.tests.cpp:<line number>|n...............................................................................|n|nException.tests.cpp:<line number>|nunexpected exception with messages:|n "answer := 42"|n "expected exception"|n REQUIRE_NOTHROW( thisThrows() )|nwith expansion:|n thisThrows()|n- failure ignore as test marked as |'ok to fail|'|n']

0 commit comments

Comments
 (0)