Skip to content

An easy way to boost performance (optional) #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaceKuailv opened this issue Mar 12, 2025 · 2 comments
Open

An easy way to boost performance (optional) #40

MaceKuailv opened this issue Mar 12, 2025 · 2 comments

Comments

@MaceKuailv
Copy link

This is an optional recommendation as part of the review for the joss paper openjournals/joss-reviews#7873
Feel free to close this if you don't want to implement this.

It seems like most of the function is based on numpy, except for the calculation of great_circle distance using geopy, which means you could compile most of your functions using numba decorator. Actually, it is not too hard to rewrite great_circle using just numpy.

@cassidymwagner
Copy link
Owner

Thank you for this suggestion! We are exploring a future shift of FluidSF from numpy to xarray/dask. We have seen some really nice performance boosts in the early stages of this process, not to mention the convenience of using xarray datasets. It looks like Numba can be easily used with xarray, so we will keep this in mind for the next version of FluidSF!

@MaceKuailv
Copy link
Author

Wow, I didn't know about this development with dask and numba! Glad you are thinking about the next step already.

I will keep this issue open so that I can be notified by, but this won't hinder your publishing of the joss paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants