Skip to content

Commit 3f0ecd5

Browse files
authored
[config] Remove "reset failed" print lines from config reload (sonic-net#1654)
#### What I did I removed the following line from the `config reload` flow.... ``` click.echo("Resetting failed status on {}".format(service)) ``` This is called in the `_reset_failed_services()` function which is used to reset the systemd restart timers on services so that it doesn't prevent them from starting from the config reload. The above line results in the following lines being printed to the terminal when `config reload` is run ``` Resetting failed status on <service>.service ``` This gives the impression that the listed services failed at some point in their lifetime which is untrue and misleading to print to the terminal (in addition many rich-text terminals mark keywords such as "failed" red which further increases the implied severity of these log lines). I do not believe this operation needs any verbosity as it is a very simple operation that makes no user-visible changes thus the user should not need to be notified of it.
1 parent 285960d commit 3f0ecd5

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

config/main.py

-1
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,6 @@ def _get_sonic_services():
683683

684684
def _reset_failed_services():
685685
for service in _get_sonic_services():
686-
click.echo("Resetting failed status on {}".format(service))
687686
clicommon.run_command("systemctl reset-failed {}".format(service))
688687

689688

0 commit comments

Comments
 (0)