Skip to content

Commit 046454a

Browse files
fix(multple): edited broken and incorrect links (#1359)
* fix(multple): edited broken and incorrect links * fix(multiple): removed unecessary cards and fixed some more links * fix(multiple): overall url fix for carbondesignsystem elements pages * fix(app-icons): fixed typo on design tab
1 parent 9ca7707 commit 046454a

File tree

8 files changed

+17
-45
lines changed

8 files changed

+17
-45
lines changed

src/pages/2x-grid.mdx

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ within it.
380380
<ResourceCard
381381
subTitle="2x Grid in UI: The mini unit"
382382
aspectRatio="2:1"
383-
href="https://www.carbondesignsystem.com/guidelines/2x-grid/overview#mini-unit"
383+
href="https://carbondesignsystem.com/elements/2x-grid/overview#mini-unit"
384384
>
385385

386386

@@ -430,7 +430,7 @@ baseline grid to guide your content.
430430
<ResourceCard
431431
subTitle="IBM type scale"
432432
aspectRatio="2:1"
433-
href="/typography/type-specs-ui/#scales"
433+
href="/typography/type-scale"
434434
actionIcon="arrowRight"
435435
>
436436

@@ -507,24 +507,11 @@ interfaces, please visit
507507
<ResourceCard
508508
subTitle="2x Grid in UI: Overview"
509509
aspectRatio="2:1"
510-
href="https://www.carbondesignsystem.com/guidelines/2x-grid/overview"
510+
href="https://carbondesignsystem.com/elements/2x-grid/overview"
511511
actionIcon="launch"
512512
>
513513

514514

515-
![carbon icon](../images/resource-cards/carbon.png)
516-
517-
</ResourceCard>
518-
</Column>
519-
<Column colMd={4} colLg={4} noGutterSm>
520-
<ResourceCard
521-
subTitle="2x Grid in UI: Implementation"
522-
aspectRatio="2:1"
523-
actionIcon="launch"
524-
href="https://www.carbondesignsystem.com/guidelines/2x-grid/implementation"
525-
>
526-
527-
528515
![carbon icon](../images/resource-cards/carbon.png)
529516

530517
</ResourceCard>

src/pages/animation/overview.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ complex, ambient loop to feature brand film.
238238
<Column colMd={4} colLg={4} noGutterSm>
239239
<ResourceCard
240240
subTitle="Motion in UI"
241-
href="https://www.carbondesignsystem.com/guidelines/motion/overview"
241+
href="https://www.carbondesignsystem.com/elements/motion/overview"
242242
>
243243

244244
![carbon Icon](../../images/resource-cards/carbon.png)

src/pages/color.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ are used sparingly and purposefully.
250250
<ResourceCard
251251
subTitle="Color in UI"
252252
aspectRatio="2:1"
253-
href="https://www.carbondesignsystem.com/guidelines/color/overview"
253+
href="https://www.carbondesignsystem.com/elements/color/overview"
254254
>
255255

256256
![CarbonIcon](../images/resource-cards/carbon.png)

src/pages/data-visualization/design/basics.mdx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ elements and make changes in the data set or on the environment explicit, clear
307307
and unambiguous. Consider the entrance and exit motions to enhance the visual
308308
hierarchy of elements, orientation of axes and the data displayed. Be careful
309309
not to communicate contradicting information with different transitions.
310-
[Learn more on Carbon](https://www.carbondesignsystem.com/guidelines/motion/overview).
310+
[Learn more on Carbon](https://www.carbondesignsystem.com/elements/motion/overview).
311311

312312
</Column>
313313
</Row>
@@ -333,6 +333,3 @@ not to communicate contradicting information with different transitions.
333333

334334
</DoDont>
335335
</DoDontRow>
336-
337-
338-

src/pages/iconography/app-icons/design.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ of the app with more simplicity and abstraction. These icons should focus on the
346346
bigger concepts of the product or service, such as scale, transaction,
347347
integration and so on.  Functionally, fill app icons work best in situations
348348
where you need to call attention to the app with more visual weight or a larger
349-
color field, as opposed to the light, linear form of fill app icons.
349+
color field, as opposed to the light, linear form of stroke app icons.
350350

351351
<ArtDirection>
352352

src/pages/iconography/ui-icons/contribute.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ As visual symbols, IBM user interface icons represent ideas, objects or actions.
2222

2323
Don’t see the icon you need in the library? Make your own! Follow these guidelines to ensure visual consistency and proper formatting.
2424

25-
- All icons should be unique and not redundant with any existing icons in the system. Search the [library](https://www.carbondesignsystem.com/guidelines/icons/library) for the keyword(s) associated with your proposed new icon to ensure that it is not already represented.
25+
- All icons should be unique and not redundant with any existing icons in the system. Search the [library](https://www.carbondesignsystem.com/elements/icons/library) for the keyword(s) associated with your proposed new icon to ensure that it is not already represented.
2626
- All icons should adhere to the [IBM Design Language](/iconography/ui-icons/design) visual style.
2727
- All icons should comply with IBM [accessibility standards](https://www.carbondesignsystem.com/guidelines/accessibility/overview).
2828
- All icons should be usable across all supported platforms and devices.
@@ -78,7 +78,7 @@ Does your icon have potential for other products at IBM? If so, please consider
7878

7979
### Getting started
8080

81-
Before submitting artwork, first review our [icons library](https://www.carbondesignsystem.com/guidelines/icons/library/) or download the [Carbon icon master .ai file](https://github.com/carbon-design-system/carbon/tree/master/packages/icons/master) to check your design for duplication against existing icons.
81+
Before submitting artwork, first review our [icons library](https://www.carbondesignsystem.com/elements/icons/library) or download the [Carbon icon master .ai file](https://github.com/carbon-design-system/carbon/tree/master/packages/icons/master) to check your design for duplication against existing icons.
8282

8383
### Approval process
8484

src/pages/layout/tips-and-techniques.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ rhythm emerges.
5757

5858
#### 2x Grid
5959

60-
[The 2x Grid](/elements/2x-grid) is the scaffolding on which IBM designers
60+
The [2x Grid](/2x-grid) is the scaffolding on which IBM designers
6161
create structural rhythm. It provides structural, proportional, and spatial
6262
guidance for design within any media. Skillful use of it will yield harmonious
6363
spatial relationships between canvas and content while expressing our distinct
@@ -68,7 +68,7 @@ point-of-view.
6868
#### Sizing scale
6969

7070
In lieu of concrete vertical divisions, such as on a web page, the
71-
[sizing scale](https://www.carbondesignsystem.com/guidelines/layout#sizing-scale)
71+
[sizing scale](https://www.carbondesignsystem.com/elements/2x-grid/overview/#sizing-scale)
7272
is helpful in establishing vertical rhythm. Like a type scale, the sizing scale
7373
constrains the range of sizes to improve consistency and rhythm, while still
7474
allowing a wide range of sizes.
@@ -153,7 +153,7 @@ Typographic hierarchy is the navigational system that renders complex
153153
information accessible. Think of a book outline; the size, style, and position
154154
of type not only informs what order it should be read, but also describes the
155155
parent-child relationships of the content. Effective use of the
156-
[type scale](https://www.ibm.com/design/language/elements/type-specs-ui), along
156+
[type scale](/typography/type-scale), along
157157
with an understanding of
158158
[Gestalt principles](https://www.interaction-design.org/literature/topics/gestalt-principles),
159159
will ensure your design can be easily navigated and understood.
@@ -181,7 +181,7 @@ Facilitating eye movement through the composition creates a more interesting
181181
design. A focal point instantly attracts the eye to one area of the canvas.
182182
Secondary and tertiary elements then draw the eye across the canvas, creating
183183
more engagement between the viewer and the design. This is done best through
184-
[asymmetric layouts](/elements/layout/tips-and-techniques/#master-asymmetry),
184+
[asymmetric layouts](/layout/tips-and-techniques/#master-asymmetry),
185185
where thoughtful relationships between elements make for a more visually
186186
stimulating design. It's important to plan the movement of the eye in order to
187187
guide the viewer to the intended outcome.

src/pages/resources.mdx

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ the alternatives shown here.
164164
<Column colMd={4} colLg={4} noGutterSm>
165165
<ResourceCard
166166
subTitle="Color in UI"
167-
href="https://www.carbondesignsystem.com/guidelines/color/overview"
167+
href="https://www.carbondesignsystem.com/elements/color/overview"
168168
>
169169

170170
![carbon Icon](../images/resource-cards/carbon.png)
@@ -202,19 +202,7 @@ href="https://marijohannessen.github.io/color-contrast-checker/"
202202
<ResourceCard
203203
subTitle="2x Grid in UI: Overview"
204204
aspectRatio="2:1"
205-
href="https://www.carbondesignsystem.com/guidelines/2x-grid/overview"
206-
>
207-
208-
![carbon icon](../images/resource-cards/carbon.png)
209-
210-
</ResourceCard>
211-
</Column>
212-
213-
<Column colMd={4} colLg={4} noGutterSm>
214-
<ResourceCard
215-
subTitle="2x Grid in UI: Implementation"
216-
aspectRatio="2:1"
217-
href="https://www.carbondesignsystem.com/guidelines/2x-grid/implementation"
205+
href="https://carbondesignsystem.com/elements/2x-grid/overview/"
218206
>
219207

220208
![carbon icon](../images/resource-cards/carbon.png)
@@ -239,7 +227,7 @@ href="https://www.ibm.com/design/language/files/2x_video_grid.ai"
239227
<ResourceCard
240228
subTitle="2x Grid in UI: The mini unit"
241229
aspectRatio="2:1"
242-
href="https://www.carbondesignsystem.com/guidelines/2x-grid/basics#mini-unit"
230+
href="https://carbondesignsystem.com/elements/2x-grid/overview#mini-unit"
243231
>
244232

245233
![carbon icon](../images/resource-cards/carbon.png)
@@ -603,7 +591,7 @@ href="https://developer.apple.com/design/human-interface-guidelines/macos/icons-
603591
<ResourceCard
604592
subTitle="Motion in UI"
605593
aspectRatio="2:1"
606-
href="https://www.carbondesignsystem.com/guidelines/motion/overview"
594+
href="https://www.carbondesignsystem.com/elements/motion/overview"
607595
>
608596

609597
![carbon Icon](../images/resource-cards/carbon.png)

0 commit comments

Comments
 (0)