feat: extra small buttons #19435
feat: extra small buttons #19435
Conversation
|
All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19435 +/- ##
=======================================
Coverage 84.87% 84.87%
=======================================
Files 372 372
Lines 14430 14431 +1
Branches 4694 4695 +1
=======================================
+ Hits 12247 12248 +1
Misses 2037 2037
Partials 146 146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alisonjoseph
requested review from
a team and
laurenmrice
and removed request for
a team
| @@ -150,7 +150,7 @@ export interface IconButtonProps | |||
| /** | |||
| * Specify the size of the Button. | |||
| */ | |||
| size?: Extract<ButtonSize, 'sm' | 'md' | 'lg'>; | |||
| size?: Extract<ButtonSize, 'xs' | 'sm' | 'md' | 'lg'>; | |||
There was a problem hiding this comment.
The accessibility task isn't marked as completed in #19435 (comment). Do xs IconButtons meet https://www.ibm.com/able/requirements/requirements/?version=v7_3#2_5_8?
There was a problem hiding this comment.
Yes, xs icon buttons are 24 x 24 pixels, so just meet accessibility requirements
Closes #19423
Adds support for a new "xs" button size (24px)
Changelog
New
Testing / Reviewing
Storybook (React & Web Components)
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide